Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4851)

Unified Diff: chrome/browser/extensions/extensions_ui.cc

Issue 7920023: Fix crashes related to the extension uninstall dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: make Show() pure virtual Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extensions_ui.cc
diff --git a/chrome/browser/extensions/extensions_ui.cc b/chrome/browser/extensions/extensions_ui.cc
index ca435f7930d8a7e53aceb80cfea017b65b63351d..07e21c502172e36a92abe8c1e7592196d5d64704 100644
--- a/chrome/browser/extensions/extensions_ui.cc
+++ b/chrome/browser/extensions/extensions_ui.cc
@@ -282,7 +282,7 @@ void ExtensionsDOMHandler::RegisterForNotifications() {
ExtensionUninstallDialog* ExtensionsDOMHandler::GetExtensionUninstallDialog() {
if (!extension_uninstall_dialog_.get()) {
extension_uninstall_dialog_.reset(
- new ExtensionUninstallDialog(Profile::FromWebUI(web_ui_)));
+ ExtensionUninstallDialog::Create(Profile::FromWebUI(web_ui_), this));
}
return extension_uninstall_dialog_.get();
}
@@ -413,10 +413,10 @@ void ExtensionsDOMHandler::HandleUninstallMessage(const ListValue* args) {
extension_id_prompting_ = extension_id;
- GetExtensionUninstallDialog()->ConfirmUninstall(this, extension);
+ GetExtensionUninstallDialog()->ConfirmUninstall(extension);
}
-void ExtensionsDOMHandler::ExtensionDialogAccepted() {
+void ExtensionsDOMHandler::ExtensionUninstallAccepted() {
DCHECK(!extension_id_prompting_.empty());
bool was_terminated = false;
@@ -443,7 +443,7 @@ void ExtensionsDOMHandler::ExtensionDialogAccepted() {
HandleRequestExtensionsData(NULL);
}
-void ExtensionsDOMHandler::ExtensionDialogCanceled() {
+void ExtensionsDOMHandler::ExtensionUninstallCanceled() {
extension_id_prompting_ = "";
}
« no previous file with comments | « chrome/browser/extensions/extensions_ui.h ('k') | chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698