Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 7920006: Fix asserts and GC unsafeness in stub generation, bug=1689. (Closed)

Created:
9 years, 3 months ago by Erik Corry
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix asserts and GC unsafeness in stub generation, bug=1689 . Committed: http://code.google.com/p/v8/source/detail?r=9311

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -9 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +13 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/code-stubs.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +10 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/isolate.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +11 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mozilla/mozilla.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
9 years, 3 months ago (2011-09-16 12:48:53 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 3 months ago (2011-09-16 12:51:51 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698