Fix asserts and GC unsafeness in stub generation, bug=1689.

src/mips/code-stubs-mips.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3300 matching lines @@
 
 void TranscendentalCacheStub::GenerateCallCFunction(MacroAssembler* masm,
                                                     Register scratch) {
   __ push(ra);
   __ PrepareCallCFunction(2, scratch);
   if (IsMipsSoftFloatABI) {
     __ Move(a0, a1, f4);
   } else {
     __ mov_d(f12, f4);
   }
+  AllowExternalCallThatCantCauseGC scope(masm);
   switch (type_) {
     case TranscendentalCache::SIN:
       __ CallCFunction(
           ExternalReference::math_sin_double_function(masm->isolate()),
           0, 1);
       break;
     case TranscendentalCache::COS:
       __ CallCFunction(
           ExternalReference::math_cos_double_function(masm->isolate()),
           0, 1);
@@ skipping 139 matching lines @@
   __ TailCallRuntime(Runtime::kMath_pow_cfunction, 2, 1);
 }
 
 
 bool CEntryStub::NeedsImmovableCode() {
   return true;
 }
 
 
 bool CEntryStub::CompilingCallsToThisStubIsGCSafe() {
-  return !save_doubles_ && result_size_ == 1;
+  return (!save_doubles_ || ISOLATE->fp_stubs_generated()) &&
+          result_size_ == 1;
 }
 
 
 void CodeStub::GenerateStubsAheadOfTime() {
 }
 
 
+void CodeStub::GenerateFPStubs() {
+  CEntryStub save_doubles(1);
+  save_doubles.SaveDoubles();
+  Handle<Code> code = save_doubles.GetCode();
+  code->GetIsolate()->set_fp_stubs_generated(true);
+}
+
+
 void CEntryStub::GenerateThrowTOS(MacroAssembler* masm) {
   __ Throw(v0);
 }
 
 
 void CEntryStub::GenerateThrowUncatchable(MacroAssembler* masm,
                                           UncatchableExceptionType type) {
   __ ThrowUncatchable(type, v0);
 }
 
@@ skipping 3499 matching lines @@
   __ mov(result, zero_reg);
   __ Ret();
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_MIPS