Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4899)

Unified Diff: chrome/browser/spellchecker/spellcheck_host.h

Issue 7919003: Remove refptr usages from SpellCheckHost (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellcheck_host.h
diff --git a/chrome/browser/spellchecker/spellcheck_host.h b/chrome/browser/spellchecker/spellcheck_host.h
index ef08f349baf80509fd266c8e4bbe3fb20ac1b5cc..7da8d4de7f4502ac4a554d29655903f2b59b0ec4 100644
--- a/chrome/browser/spellchecker/spellcheck_host.h
+++ b/chrome/browser/spellchecker/spellcheck_host.h
@@ -10,6 +10,7 @@
#include <vector>
#include "base/gtest_prod_util.h"
+#include "base/memory/scoped_ptr.h"
#include "base/memory/ref_counted.h"
Hironori Bono 2011/10/14 10:57:04 nit: we do not need this line any longer once we r
#include "base/platform_file.h"
#include "content/browser/browser_thread.h"
@@ -48,9 +49,7 @@ class URLRequestContextGetter;
// retrieve the instance via Profile::GetSpellCheckHost().
// Users should not hold the reference over the function scope because
// the instance can be invalidated during the browser's lifecycle.
-class SpellCheckHost
- : public base::RefCountedThreadSafe<SpellCheckHost,
- BrowserThread::DeleteOnFileThread> {
+class SpellCheckHost {
public:
// Event types used for reporting the status of this class and its derived
// classes to browser tests.
@@ -62,7 +61,7 @@ class SpellCheckHost
virtual ~SpellCheckHost() {}
// Creates the instance of SpellCheckHost implementation object.
- static scoped_refptr<SpellCheckHost> Create(
+ static scoped_ptr<SpellCheckHost> Create(
Hironori Bono 2011/10/14 10:57:04 We can change this return type to SpellCheckHost*
SpellCheckProfileProvider* profile,
const std::string& language,
net::URLRequestContextGetter* request_context_getter,
« no previous file with comments | « no previous file | chrome/browser/spellchecker/spellcheck_host.cc » ('j') | chrome/browser/spellchecker/spellcheck_host.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698