Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: chrome/browser/spellchecker/spellcheck_host.cc

Issue 7919003: Remove refptr usages from SpellCheckHost (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellcheck_host.cc
diff --git a/chrome/browser/spellchecker/spellcheck_host.cc b/chrome/browser/spellchecker/spellcheck_host.cc
index bfdad0fad4422b538eb1b3b35e15c681ebed4510..4a2b981da12d5c7137e62110c17b675492b88420 100644
--- a/chrome/browser/spellchecker/spellcheck_host.cc
+++ b/chrome/browser/spellchecker/spellcheck_host.cc
@@ -23,18 +23,17 @@ SpellCheckHost::EventType g_status_type = SpellCheckHost::BDICT_NOTINITIALIZED;
} // namespace
// static
-scoped_refptr<SpellCheckHost> SpellCheckHost::Create(
+scoped_ptr<SpellCheckHost> SpellCheckHost::Create(
Hironori Bono 2011/10/14 10:57:04 When we change the return value to SpellChekHost*,
SpellCheckProfileProvider* profile,
const std::string& language,
net::URLRequestContextGetter* request_context_getter,
SpellCheckHostMetrics* metrics) {
- scoped_refptr<SpellCheckHostImpl> host =
+ scoped_ptr<SpellCheckHostImpl> host;
+ host.reset(
Hironori Bono 2011/10/14 10:57:04 When we change the return value to SpellCheckHost*
new SpellCheckHostImpl(profile,
language,
request_context_getter,
- metrics);
- if (!host)
- return NULL;
+ metrics));
host->Initialize();
return host;

Powered by Google App Engine
This is Rietveld 408576698