Issue 7918035: Disables code for making sure window to attach to is visible on

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7918035: Disables code for making sure window to attach to is visible on (Closed)

Created:
9 years, 3 months ago by sky

Modified:
9 years, 3 months ago

Reviewers:
cpu_(ooo_6.6-7.5), brettw, Ben Goodger (Google)

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Disables code for making sure window to attach to is visible on win8. This is temporary until I find a better way to go about this. BUG=96646 TEST=make sure you can attach tabs on win8. R=brettw@chromium.org,cpu@chromium.org,ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101912

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -6 lines)			Patch
M	base/win/windows_version.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	base/win/windows_version.cc	View	1	1 chunk	+15 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/tabs/dock_info_win.cc	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/flash_ui.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

Ben Goodger (Google)

LGTM On Fri, Sep 16, 2011 at 3:27 PM, <brettw@chromium.org> wrote: > LGTM > > ...

9 years, 3 months ago (2011-09-16 23:10:42 UTC) #3

sky

Carlos wanted a VERSION_WIN_LAST, so I updated this slightly. -Scott

9 years, 3 months ago (2011-09-16 23:18:52 UTC) #4

lgtm