Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: chrome/browser/ui/tabs/dock_info_win.cc

Issue 7918035: Disables code for making sure window to attach to is visible on (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Version change from Carlos Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/win/windows_version.cc ('k') | chrome/browser/ui/webui/flash_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/tabs/dock_info_win.cc
diff --git a/chrome/browser/ui/tabs/dock_info_win.cc b/chrome/browser/ui/tabs/dock_info_win.cc
index 776a77244310dec91fc5c09ad7ff730199d96b6f..3c39e91b93b0620b6f5f73194610dde1cbb18ec2 100644
--- a/chrome/browser/ui/tabs/dock_info_win.cc
+++ b/chrome/browser/ui/tabs/dock_info_win.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/tabs/dock_info.h"
#include "base/win/scoped_gdi_object.h"
+#include "base/win/windows_version.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
@@ -146,9 +147,14 @@ class LocalProcessWindowFinder : public BaseWindowFinder {
static HWND GetProcessWindowAtPoint(const gfx::Point& screen_loc,
const std::set<HWND>& ignore) {
LocalProcessWindowFinder finder(screen_loc, ignore);
+ // Windows 8 has a window that appears first in the list of iterated
+ // windows, yet is not visually on top of everything.
+ // TODO(sky): figure out a better way to ignore this window.
if (finder.result_ &&
- TopMostFinder::IsTopMostWindowAtPoint(finder.result_, screen_loc,
- ignore)) {
+ ((base::win::OSInfo::GetInstance()->version() >=
+ base::win::VERSION_WIN8) ||
+ TopMostFinder::IsTopMostWindowAtPoint(finder.result_, screen_loc,
+ ignore))) {
return finder.result_;
}
return NULL;
« no previous file with comments | « base/win/windows_version.cc ('k') | chrome/browser/ui/webui/flash_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698