Issue 7918011: Print Preview: Disable right click -> "Save As" for preview PDF. Users should just print to PDF i...

Issue 7918011: Print Preview: Disable right click -> "Save As" for preview PDF. Users should just print to PDF i... (Closed)

Created:
9 years, 3 months ago by Lei Zhang

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, brettw

CC:
chromium-reviews, Avi (use Gerrit), brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Print Preview: Disable right click -> "Save As" for preview PDF. Users should just print to PDF instead. BUG=96310 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101888

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -5 lines)			Patch
M	chrome/browser/printing/print_preview_tab_controller.h	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/printing/print_preview_tab_controller.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

brettw

http://codereview.chromium.org/7918011/diff/2001/chrome/browser/tab_contents/render_view_context_menu.cc File chrome/browser/tab_contents/render_view_context_menu.cc (right): http://codereview.chromium.org/7918011/diff/2001/chrome/browser/tab_contents/render_view_context_menu.cc#newcode1197 chrome/browser/tab_contents/render_view_context_menu.cc:1197: !(url.SchemeIs(chrome::kChromeUIScheme) && This code is getting a bit crazy. ...

9 years, 3 months ago (2011-09-16 05:19:13 UTC) #2

Lei Zhang

9 years, 3 months ago (2011-09-16 20:00:50 UTC) #3

Change committed as 101888

Expand Messages | Collapse Messages