Print Preview: Disable right click -> "Save As" for preview PDF. Users should just print to PDF i...

chrome/browser/tab_contents/render_view_context_menu.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <set>
 
 #include "chrome/browser/tab_contents/render_view_context_menu.h"
 
 #include "base/command_line.h"
@@ skipping 1172 matching lines @@
     case IDC_CONTENT_CONTEXT_COPYIMAGELOCATION:
       return params_.src_url.is_valid();
 
     case IDC_CONTENT_CONTEXT_SAVEAVAS: {
       PrefService* local_state = g_browser_process->local_state();
       DCHECK(local_state);
       // Test if file-selection dialogs are forbidden by policy.
       if (!local_state->GetBoolean(prefs::kAllowFileSelectionDialogs))
         return false;
 
-      return (params_.media_flags &
-              WebContextMenuData::MediaCanSave) &&
-             params_.src_url.is_valid() &&
-             ProfileIOData::IsHandledProtocol(params_.src_url.scheme());
+      const GURL& url = params_.src_url;
+      return (params_.media_flags & WebContextMenuData::MediaCanSave) &&
+          url.is_valid() && ProfileIOData::IsHandledProtocol(url.scheme()) &&
+          // Do not save the preview PDF on the print preview page.
+          !(url.SchemeIs(chrome::kChromeUIScheme) &&

[brettw, 2011/09/16 05:19:14]

This code is getting a bit crazy. Can you make a local helper function
IsPrintPreviewURL(const GURL&) that you call here instead?

[Lei Zhang, 2011/09/16 20:00:50]

Done.

+            url.host() == chrome::kChromeUIPrintHost);
     }
 
     case IDC_CONTENT_CONTEXT_OPENAVNEWTAB:
       return true;
 
     case IDC_SAVE_PAGE: {
       PrefService* local_state = g_browser_process->local_state();
       DCHECK(local_state);
       // Test if file-selection dialogs are forbidden by policy.
       if (!local_state->GetBoolean(prefs::kAllowFileSelectionDialogs))
@@ skipping 733 matching lines @@
       g_browser_process->clipboard());
 }
 
 void RenderViewContextMenu::MediaPlayerActionAt(
     const gfx::Point& location,
     const WebMediaPlayerAction& action) {
   RenderViewHost* rvh = source_tab_contents_->render_view_host();
   rvh->Send(new ViewMsg_MediaPlayerActionAt(
       rvh->routing_id(), location, action));
 }