Issue 791003: Add libdbus-glib dependency into install-build-deps.sh...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 791003: Add libdbus-glib dependency into install-build-deps.sh... (Closed)

Created:
10 years, 9 months ago by joth

Modified:
9 years, 7 months ago

Reviewers:
agl, piman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add libdbus-glib dependency into install-build-deps.sh Needed as a precursor to http://codereview.chromium.org/787003 BUG=http://crbug.com/37199 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41182

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	build/install-build-deps.sh	View		2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

joth

Hi Adam, Are you happy to review this too? Slightly concerned about the mismatch in ...

10 years, 9 months ago (2010-03-10 11:38:06 UTC) #1

agl

Sorry, this got list in the morning email flood. LGTM. (The -2 is wierd but, ...

10 years, 9 months ago (2010-03-10 19:04:33 UTC) #3

joth

10 years, 9 months ago (2010-03-10 19:06:19 UTC) #4

Thanks both!

Committed revision 41182.


On 10 March 2010 19:04, <agl@chromium.org> wrote:

> Sorry, this got list in the morning email flood. LGTM.
>
> (The -2 is wierd but, if it works, then that's just life :)
>
>
> http://codereview.chromium.org/791003
>

Expand Messages | Collapse Messages