Issue 7908005: Fix some asserts in stub generation and file some bugs where

Issue 7908005: Fix some asserts in stub generation and file some bugs where (Closed)

Created:
9 years, 3 months ago by Erik Corry

Modified:
9 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix some asserts in stub generation and file some bugs where we appear to have valid asserts triggering. Committed: http://code.google.com/p/v8/source/detail?r=9305

Patch Set 2 : '' #

Total comments: 4

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -3 lines)			Patch
M	src/arm/stub-cache-arm.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/macro-assembler.h	View		3 chunks	+3 lines, -3 lines	1 comment	Download
M	src/mips/stub-cache-mips.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	test/mozilla/mozilla.status	View	1	1 chunk	+3 lines, -0 lines	3 comments	Download
M	test/sputnik/sputnik.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM http://codereview.chromium.org/7908005/diff/3001/src/macro-assembler.h File src/macro-assembler.h (right): http://codereview.chromium.org/7908005/diff/3001/src/macro-assembler.h#newcode1 src/macro-assembler.h:1: // Copyright 2006-2008 the V8 project authors. All ...

9 years, 3 months ago (2011-09-15 15:41:09 UTC) #3

Erik Corry

9 years, 3 months ago (2011-09-15 19:29:16 UTC) #4

http://codereview.chromium.org/7908005/diff/3001/test/mozilla/mozilla.status
File test/mozilla/mozilla.status (right):

http://codereview.chromium.org/7908005/diff/3001/test/mozilla/mozilla.status#...
test/mozilla/mozilla.status:73: js1_5/Regress/regress-103602: SKIP
On 2011/09/15 15:41:09, Jakob wrote:
> I don't see any assertions triggered by regress-103602 (it's been marked
failing
> earlier today due to an unrelated change).

Good catch.

Expand Messages | Collapse Messages