Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 7908005: Fix some asserts in stub generation and file some bugs where (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/macro-assembler.h » ('j') | src/macro-assembler.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 574 matching lines...) Expand 10 before | Expand all | Expand 10 after
585 585
586 // r2 points to call data as expected by Arguments 586 // r2 points to call data as expected by Arguments
587 // (refer to layout above). 587 // (refer to layout above).
588 __ add(r2, sp, Operand(2 * kPointerSize)); 588 __ add(r2, sp, Operand(2 * kPointerSize));
589 589
590 Object* callback = optimization.api_call_info()->callback(); 590 Object* callback = optimization.api_call_info()->callback();
591 Address api_function_address = v8::ToCData<Address>(callback); 591 Address api_function_address = v8::ToCData<Address>(callback);
592 ApiFunction fun(api_function_address); 592 ApiFunction fun(api_function_address);
593 593
594 const int kApiStackSpace = 4; 594 const int kApiStackSpace = 4;
595
596 FrameScope frame_scope(masm, StackFrame::MANUAL);
595 __ EnterExitFrame(false, kApiStackSpace); 597 __ EnterExitFrame(false, kApiStackSpace);
596 598
597 // r0 = v8::Arguments& 599 // r0 = v8::Arguments&
598 // Arguments is after the return address. 600 // Arguments is after the return address.
599 __ add(r0, sp, Operand(1 * kPointerSize)); 601 __ add(r0, sp, Operand(1 * kPointerSize));
600 // v8::Arguments::implicit_args = data 602 // v8::Arguments::implicit_args = data
601 __ str(r2, MemOperand(r0, 0 * kPointerSize)); 603 __ str(r2, MemOperand(r0, 0 * kPointerSize));
602 // v8::Arguments::values = last argument 604 // v8::Arguments::values = last argument
603 __ add(ip, r2, Operand(argc * kPointerSize)); 605 __ add(ip, r2, Operand(argc * kPointerSize));
604 __ str(ip, MemOperand(r0, 1 * kPointerSize)); 606 __ str(ip, MemOperand(r0, 1 * kPointerSize));
(...skipping 621 matching lines...) Expand 10 before | Expand all | Expand 10 after
1226 } else { 1228 } else {
1227 __ Move(scratch3, Handle<Object>(callback_handle->data())); 1229 __ Move(scratch3, Handle<Object>(callback_handle->data()));
1228 } 1230 }
1229 __ Push(reg, scratch3, name_reg); 1231 __ Push(reg, scratch3, name_reg);
1230 __ mov(r0, sp); // r0 = Handle<String> 1232 __ mov(r0, sp); // r0 = Handle<String>
1231 1233
1232 Address getter_address = v8::ToCData<Address>(callback->getter()); 1234 Address getter_address = v8::ToCData<Address>(callback->getter());
1233 ApiFunction fun(getter_address); 1235 ApiFunction fun(getter_address);
1234 1236
1235 const int kApiStackSpace = 1; 1237 const int kApiStackSpace = 1;
1238
1239 FrameScope frame_scope(masm(), StackFrame::MANUAL);
1236 __ EnterExitFrame(false, kApiStackSpace); 1240 __ EnterExitFrame(false, kApiStackSpace);
1241
1237 // Create AccessorInfo instance on the stack above the exit frame with 1242 // Create AccessorInfo instance on the stack above the exit frame with
1238 // scratch2 (internal::Object **args_) as the data. 1243 // scratch2 (internal::Object **args_) as the data.
1239 __ str(scratch2, MemOperand(sp, 1 * kPointerSize)); 1244 __ str(scratch2, MemOperand(sp, 1 * kPointerSize));
1240 __ add(r1, sp, Operand(1 * kPointerSize)); // r1 = AccessorInfo& 1245 __ add(r1, sp, Operand(1 * kPointerSize)); // r1 = AccessorInfo&
1241 1246
1242 // Emitting a stub call may try to allocate (if the code is not 1247 // Emitting a stub call may try to allocate (if the code is not
1243 // already generated). Do not allow the assembler to perform a 1248 // already generated). Do not allow the assembler to perform a
1244 // garbage collection but instead return the allocation failure 1249 // garbage collection but instead return the allocation failure
1245 // object. 1250 // object.
1246 const int kStackUnwindSpace = 4; 1251 const int kStackUnwindSpace = 4;
(...skipping 3181 matching lines...) Expand 10 before | Expand all | Expand 10 after
4428 masm->isolate()->builtins()->KeyedStoreIC_MissForceGeneric(); 4433 masm->isolate()->builtins()->KeyedStoreIC_MissForceGeneric();
4429 __ Jump(ic, RelocInfo::CODE_TARGET); 4434 __ Jump(ic, RelocInfo::CODE_TARGET);
4430 } 4435 }
4431 4436
4432 4437
4433 #undef __ 4438 #undef __
4434 4439
4435 } } // namespace v8::internal 4440 } } // namespace v8::internal
4436 4441
4437 #endif // V8_TARGET_ARCH_ARM 4442 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/macro-assembler.h » ('j') | src/macro-assembler.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698