Fix a typo that resulted in no tests to be run in depot_tools. :(

Fix a typo that resulted in no tests to be run in depot_tools. :(

Add a warning when RunUnitTestsInDirectory() finds no test to run to
catch this kind of regression.

Fix all the regressions that where introduced in the meantime...

TBR=dpranke@chromium.org
BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101347

[M-A Ruel, 2011-09-15 18:34:37]

TBR'ing since I don't want other bad changes to come in in the meantime.

Mocking Popen and communicate is enough to mock all of subprocess2.

http://codereview.chromium.org/7906009/diff/1/presubmit_support.py
File presubmit_support.py (right):

http://codereview.chromium.org/7906009/diff/1/presubmit_support.py#newcode1078
presubmit_support.py:1078: output.write("Warning, no PRESUBMIT.py found.\n")
presubmit.py felt odd.

[commit-bot: I haz the power, 2011-09-15 18:44:10]

Presubmit check for 7906009-1 failed and returned exit status 1.

Running presubmit commit checks ...
Syncing rietveld...
Running push-basic.sh
Running save-description-on-failure.sh
Running basic.sh
Running upload-stale.sh
Running upload-local-tracking-branch.sh
Running patch.sh
Running submit-from-new-dir.sh
Running post-dcommit-hook-test.sh
Running hooks.sh
Running abandon.sh
Running upstream.sh

** Presubmit Messages **
You should install python 2.5 and run ln -s $(which python2.5) python.
A great place to put this symlink is in depot_tools.
Otherwise, you break depot_tools on python 2.5, you get to keep the pieces.

--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
tests/gclient_smoketest.py failed!
Command tests/gclient_smoketest.py returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools
.......F................................
======================================================================
FAIL: testMultiSolutionsJobs (__main__.GClientSmokeBoth)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1046, in testMultiSolutionsJobs
    untangle=True)
  File "tests/gclient_smoketest.py", line 77, in parseGclient
    return self.checkBlock(stdout, items)
  File "tests/gclient_smoketest.py", line 137, in checkBlock
    self.checkString(results[i][0][2], path, (i, results[i][0][2], path))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/fake_repos.py",
line 682, in checkString
    self.assertEquals(expected, result, msg)
AssertionError: (3,
'/tmp/trialN7WRLi/__main__.GClientSmokeBoth.testMultiSolutionsJobs',
'/tmp/trialN7WRLi/__main__.GClientSmokeBoth.testMultiSolutionsJobs/src/file/other')

----------------------------------------------------------------------
Ran 40 tests in 178.199s

FAILED (failures=1)


tests/gclient_scm_test.py failed!
Command tests/gclient_scm_test.py returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools
...........EE...................
======================================================================
ERROR: testUpdateUnstagedConflict (__main__.GitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 759, in testUpdateUnstagedConflict
    scm.update(options, (), [])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/gclient_scm.py", line
398, in update
    raise gclient_utils.Error(e.stderr)
Error: error: Your local changes to 'b' would be overwritten by merge. 
Aborting.
Please, commit your changes or stash them before you can merge.


======================================================================
ERROR: testUpdateUnstagedConflict (__main__.GitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 541, in tearDown
    StdoutCheck.tearDown(self)
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/super_mox.py",
line 100, in tearDown
    self.assertEquals('', sys.stdout.getvalue())
AssertionError: '' != '\n_____ . at refs/heads/master\n'

----------------------------------------------------------------------
Ran 31 tests in 1.775s

FAILED (errors=2)


Presubmit checks took 361.5s to calculate.

[commit-bot: I haz the power, 2011-09-15 18:58:04]

Change committed as 101347

[Dirk Pranke, 2011-09-15 19:02:44]

LGTM.