Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Unified Diff: tests/scm_unittest.py

Issue 7906009: Fix a typo that resulted in no tests to be run in depot_tools. :( (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: More Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/presubmit_unittest.py ('k') | tests/super_mox.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/scm_unittest.py
diff --git a/tests/scm_unittest.py b/tests/scm_unittest.py
index 21150f3ff8e7053bfa7ca6b78fb622a75fe08c27..6b4faf3587b13ca1fb6038a76210d33367ba1821 100755
--- a/tests/scm_unittest.py
+++ b/tests/scm_unittest.py
@@ -16,6 +16,7 @@ from super_mox import SuperMoxTestBase
import fake_repos
import scm
+import subprocess2
class BaseTestCase(SuperMoxTestBase):
@@ -32,10 +33,10 @@ class BaseTestCase(SuperMoxTestBase):
class BaseSCMTestCase(BaseTestCase):
def setUp(self):
BaseTestCase.setUp(self)
- self.mox.StubOutWithMock(scm.gclient_utils, 'CheckCall')
self.mox.StubOutWithMock(scm.gclient_utils, 'CheckCallAndFilter')
self.mox.StubOutWithMock(scm.gclient_utils, 'CheckCallAndFilterAndHeader')
- self.mox.StubOutWithMock(scm.gclient_utils, 'Popen')
+ self.mox.StubOutWithMock(subprocess2, 'Popen')
+ self.mox.StubOutWithMock(subprocess2, 'communicate')
class RootTestCase(BaseSCMTestCase):
@@ -45,7 +46,7 @@ class RootTestCase(BaseSCMTestCase):
'ElementTree', 'GetCasedPath', 'GenFakeDiff', 'GIT', 'SVN',
'ValidateEmail',
'cStringIO', 'determine_scm', 'gclient_utils', 'glob', 'logging', 'os',
- 're', 'shutil', 'subprocess', 'subprocess2', 'sys', 'tempfile', 'time',
+ 're', 'subprocess2', 'sys', 'tempfile', 'time',
]
# If this test fails, you should add the relevant test.
self.compareMembers(scm, members)
« no previous file with comments | « tests/presubmit_unittest.py ('k') | tests/super_mox.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698