Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 7906003: Tickprocessor no longer prints error messages on log entries that are unrelated to profiling. (Closed)

Created:
9 years, 3 months ago by Yang
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Tickprocessor no longer prints error messages on log entries that are unrelated to profiling. BUG=v8:1683 Committed: http://code.google.com/p/v8/source/detail?r=9302

Patch Set 1 #

Total comments: 1

Patch Set 2 : Restoring exception checking. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M tools/logreader.js View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
I think it is unnecessary to print error messages on unknown commands in the log ...
9 years, 3 months ago (2011-09-15 11:47:16 UTC) #1
mnaganov (inactive)
Thanks for looking into this! http://codereview.chromium.org/7906003/diff/1/tools/logreader.js File tools/logreader.js (left): http://codereview.chromium.org/7906003/diff/1/tools/logreader.js#oldcode182 tools/logreader.js:182: this.printError('line ' + (this.lineNum_ ...
9 years, 3 months ago (2011-09-15 12:39:29 UTC) #2
Yang
I restored catching the exceptions. Still omitting the error printing on unknown command. Please take ...
9 years, 3 months ago (2011-09-15 12:52:37 UTC) #3
mnaganov (inactive)
9 years, 3 months ago (2011-09-15 13:11:48 UTC) #4
On 2011/09/15 12:52:37, Yang wrote:
> I restored catching the exceptions. Still omitting the error printing on
unknown
> command. Please take another look.

Thanks! LGTM.

Powered by Google App Engine
This is Rietveld 408576698