tools/logreader.js - Issue 7906003: Tickprocessor no longer prints error messages on log entries that are unrelated to profiling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/logreader.js

Issue 7906003: Tickprocessor no longer prints error messages on log entries that are unrelated to profiling. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Restoring exception checking. Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/logreader.js

diff --git a/tools/logreader.js b/tools/logreader.js

index 315e72127608f01d075d475d9112c7f2ec997fd2..e37c8eaf543527adcddc3e40787b047f9dd25eca 100644

--- a/tools/logreader.js

+++ b/tools/logreader.js

@@ -134,9 +134,8 @@ LogReader.prototype.skipDispatch = function(dispatch) {

LogReader.prototype.dispatchLogRow_ = function(fields) {

// Obtain the dispatch.

var command = fields[0];

- if (!(command in this.dispatchTable_)) {

- throw new Error('unknown command: ' + command);

- }

+ if (!(command in this.dispatchTable_)) return;

var dispatch = this.dispatchTable_[command];

if (dispatch === null || this.skipDispatch(dispatch)) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »