Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3726)

Unified Diff: chrome/browser/sync/js/js_event_details.h

Issue 7904021: [Sync] Rework SharedValue<T> into Immutable<T> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/js/js_arg_list.cc ('k') | chrome/browser/sync/js/js_event_details.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/js/js_event_details.h
diff --git a/chrome/browser/sync/js/js_event_details.h b/chrome/browser/sync/js/js_event_details.h
index 293d0ee1f9c5206843f77320a9c681a1951c7dfe..51fba049aafc3f0fd107045a41eb522ed4bfca26 100644
--- a/chrome/browser/sync/js/js_event_details.h
+++ b/chrome/browser/sync/js/js_event_details.h
@@ -10,14 +10,13 @@
#include <string>
-#include "base/memory/ref_counted.h"
#include "base/values.h"
-#include "chrome/browser/sync/util/shared_value.h"
+#include "chrome/browser/sync/util/immutable.h"
namespace browser_sync {
-// A thread-safe wrapper around an immutable DictionaryValue. Used
-// for passing around event details to different threads.
+// A thin wrapper around Immutable<DictionaryValue>. Used for passing
+// around event details to different threads.
class JsEventDetails {
public:
// Uses an empty dictionary.
@@ -35,10 +34,10 @@ class JsEventDetails {
// Copy constructor and assignment operator welcome.
private:
- typedef SharedValue<DictionaryValue, HasSwapMemFnTraits<DictionaryValue> >
- SharedDictionaryValue;
+ typedef Immutable<DictionaryValue, HasSwapMemFnByPtr<DictionaryValue> >
+ ImmutableDictionaryValue;
- scoped_refptr<const SharedDictionaryValue> details_;
+ ImmutableDictionaryValue details_;
};
} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/js/js_arg_list.cc ('k') | chrome/browser/sync/js/js_event_details.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698