chrome/browser/sync/js/js_event_details.cc - Issue 7904021: [Sync] Rework SharedValue<T> into Immutable<T>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/js/js_event_details.cc

Issue 7904021: [Sync] Rework SharedValue<T> into Immutable<T> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/js/js_event_details.cc

diff --git a/chrome/browser/sync/js/js_event_details.cc b/chrome/browser/sync/js/js_event_details.cc

index ae23d1790f60ca3342f08975a09382e8f92fccb5..9182d24c923236c4bd57a41fbba0baf8a5e794a1 100644

--- a/chrome/browser/sync/js/js_event_details.cc

+++ b/chrome/browser/sync/js/js_event_details.cc

@@ -8,16 +8,14 @@

namespace browser_sync {

-JsEventDetails::JsEventDetails()

- : details_(new SharedDictionaryValue()) {}

+JsEventDetails::JsEventDetails() {}

-JsEventDetails::JsEventDetails(DictionaryValue* details)

- : details_(new SharedDictionaryValue(details)) {}

+JsEventDetails::JsEventDetails(DictionaryValue* details) : details_(details) {}

JsEventDetails::~JsEventDetails() {}

const DictionaryValue& JsEventDetails::Get() const {

- return details_->Get();

+ return details_.Get();

}

std::string JsEventDetails::ToString() const {