Introduce with scope and rework variable resolution.

src/parser.cc

Index: src/parser.cc
diff --git a/src/parser.cc b/src/parser.cc
index e8d18106165515f7e43e58ba700d5fcf5d63a4cd..b7d367d432bb5d80e3a30f0a50d02557c5282f24 100644
--- a/src/parser.cc
+++ b/src/parser.cc
@@ -2080,7 +2080,11 @@ Statement* Parser::ParseWithStatement(ZoneStringList* labels, bool* ok) {
 
   ++with_nesting_level_;
   top_scope_->DeclarationScope()->RecordWithStatement();
+  Scope* saved_scope = top_scope_;

[Kevin Millikin (Chromium), 2011/09/15 09:38:13]

Now that we have three or four places using this pattern, we should implement a
C++ stack-allocated object that saves the scope.  Unfortunately, "LexicalScope"
is used for something not quite that.  And "ScopeScope" is to silly.  Something
like:

{ SaveScope scope(NewScope(top_scope_, Scope::WITH_SCOPE, true));
  Statement* stmt = ParseStatement(labels, CHECK_OK):
}

[Steven, 2011/09/15 19:54:06]

Done.

+  Scope* with_scope = NewScope(top_scope_, Scope::WITH_SCOPE, true);
+  top_scope_ = with_scope;
   Statement* stmt = ParseStatement(labels, CHECK_OK);
+  top_scope_ = saved_scope;
   --with_nesting_level_;
   return new(zone()) WithStatement(expr, stmt);
 }