Introduce with scope and rework variable resolution.

src/parser.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2062 matching lines @@
     *ok = false;
     return NULL;
   }
 
   Expect(Token::LPAREN, CHECK_OK);
   Expression* expr = ParseExpression(true, CHECK_OK);
   Expect(Token::RPAREN, CHECK_OK);
 
   ++with_nesting_level_;
   top_scope_->DeclarationScope()->RecordWithStatement();
+  Scope* saved_scope = top_scope_;

[Kevin Millikin (Chromium), 2011/09/15 09:38:13]

Now that we have three or four places using this pattern, we should implement a
C++ stack-allocated object that saves the scope.  Unfortunately, "LexicalScope"
is used for something not quite that.  And "ScopeScope" is to silly.  Something
like:

{ SaveScope scope(NewScope(top_scope_, Scope::WITH_SCOPE, true));
  Statement* stmt = ParseStatement(labels, CHECK_OK):
}

[Steven, 2011/09/15 19:54:06]

Done.

+  Scope* with_scope = NewScope(top_scope_, Scope::WITH_SCOPE, true);
+  top_scope_ = with_scope;
   Statement* stmt = ParseStatement(labels, CHECK_OK);
+  top_scope_ = saved_scope;
   --with_nesting_level_;
   return new(zone()) WithStatement(expr, stmt);
 }
 
 
 CaseClause* Parser::ParseCaseClause(bool* default_seen_ptr, bool* ok) {
   // CaseClause ::
   //   'case' Expression ':' Statement*
   //   'default' ':' Statement*
 
@@ skipping 3129 matching lines @@
       result = parser.ParseProgram(source,
                                    info->is_global(),
                                    info->StrictMode());
     }
   }
   info->SetFunction(result);
   return (result != NULL);
 }
 
 } }  // namespace v8::internal