Issue 7903018: More shell content.

Issue 7903018: More shell content. (Closed)

Created:
9 years, 3 months ago by Ben Goodger (Google)

Modified:
9 years, 3 months ago

Reviewers:
tfarina, sky

CC:
chromium-reviews, dhollowa, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Adds some features to the shell: - desktop background - stub launcher - clicking the background opens test windows BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101496

Patch Set 1 : '' #

Total comments: 1

Patch Set 2 : '' #

Total comments: 5

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+394 lines, -20 lines)			Patch
M	build/all.gyp	View	1	3 chunks	+7 lines, -2 lines	0 comments	Download
M	build/common.gypi	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/aura/demo/demo_main.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/aura/desktop.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/window.h	View	1	3 chunks	+6 lines, -0 lines	0 comments	Download
M	ui/aura/window.cc	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download
M	ui/aura/window_delegate.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	ui/aura/window_unittest.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/aura_shell/aura_shell.gyp	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	ui/aura_shell/aura_shell_main.cc	View	1	2 chunks	+19 lines, -12 lines	0 comments	Download
M	ui/aura_shell/desktop_background_view.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	ui/aura_shell/desktop_background_view.cc	View	1	2 chunks	+28 lines, -3 lines	1 comment	Download
M	ui/aura_shell/desktop_layout_manager.h	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
M	ui/aura_shell/desktop_layout_manager.cc	View	1	2 chunks	+15 lines, -1 line	0 comments	Download
A	ui/aura_shell/launcher/launcher_button.h	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
A	ui/aura_shell/launcher/launcher_button.cc	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
A	ui/aura_shell/launcher/launcher_view.h	View	1	1 chunk	+41 lines, -0 lines	1 comment	Download
A	ui/aura_shell/launcher/launcher_view.cc	View	1	1 chunk	+50 lines, -0 lines	2 comments	Download
A	ui/aura_shell/sample_window.h	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download
A	ui/aura_shell/sample_window.cc	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
A	ui/aura_shell/shell_factory.h	View	1	1 chunk	+26 lines, -0 lines	1 comment	Download
M	ui/aura_shell/status_area_view.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/aura_shell/status_area_view.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/gfx/screen_aura.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	ui/resources/aura/applist.png	View		Binary file		0 comments	Download
A	ui/resources/aura/browser_instance.png	View	1	Binary file		0 comments	Download
A	ui/resources/aura/chromium-48.png	View	1	Binary file		0 comments	Download
A	ui/resources/aura/damask.png	View		Binary file		0 comments	Download
A	ui/resources/aura/statusbar.png	View		Binary file		0 comments	Download
M	ui/resources/ui_resources.grd	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	views/aura_desktop/aura_desktop_main.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	views/view_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	views/widget/native_widget_aura.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	views/widget/native_widget_aura.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

I don't think we generally check in chrome icons to the public repo. http://codereview.chromium.org/7903018/diff/14001/ui/aura/window.h File ...

9 years, 3 months ago (2011-09-16 15:41:26 UTC) #2

Ben Goodger (Google)

Updated with the following changes: - use a chromium icon instead - fix windows build ...

9 years, 3 months ago (2011-09-16 16:10:48 UTC) #3

tfarina

http://codereview.chromium.org/7903018/diff/8062/ui/aura_shell/desktop_background_view.cc File ui/aura_shell/desktop_background_view.cc (right): http://codereview.chromium.org/7903018/diff/8062/ui/aura_shell/desktop_background_view.cc#newcode44 ui/aura_shell/desktop_background_view.cc:44: views::Widget* CreateDesktopBackground() { Include ui/aura_shell/shell_factory.h for this? http://codereview.chromium.org/7903018/diff/8062/ui/aura_shell/launcher/launcher_view.cc File ...

9 years, 3 months ago (2011-09-16 16:28:43 UTC) #4

LGTM

Expand Messages | Collapse Messages