Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 7903001: Improve Tab-key navigation for editing Autofill addresses and credit cards. (Closed)

Created:
9 years, 3 months ago by Ilya Sherman
Modified:
9 years, 3 months ago
CC:
chromium-reviews, GeorgeY, arv (Not doing code reviews), Ilya Sherman, dhollowa
Visibility:
Public.

Description

Improve Tab-key navigation for editing Autofill addresses and credit cards. Also clean up some of the WebUI list code. BUG=78773 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102055

Patch Set 1 #

Total comments: 15

Patch Set 2 : De-nitting #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -38 lines) Patch
M chrome/browser/resources/options/autofill_options_list.js View 2 chunks +28 lines, -19 lines 0 comments Download
M chrome/browser/resources/options/deletable_item_list.js View 1 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/inline_editable_list.js View 1 2 chunks +1 line, -13 lines 1 comment Download
M chrome/browser/resources/shared/js/cr/ui/list.js View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ilya Sherman
The diffs here are a little confusing, so I've annotated them with intents. http://codereview.chromium.org/7903001/diff/1/chrome/browser/resources/options/autofill_options_list.js File ...
9 years, 3 months ago (2011-09-15 04:10:39 UTC) #1
James Hawkins
+arv since he wrote list.js http://codereview.chromium.org/7903001/diff/1/chrome/browser/resources/options/autofill_options_list.js File chrome/browser/resources/options/autofill_options_list.js (right): http://codereview.chromium.org/7903001/diff/1/chrome/browser/resources/options/autofill_options_list.js#newcode325 chrome/browser/resources/options/autofill_options_list.js:325: if (selectedItem) Is there ...
9 years, 3 months ago (2011-09-15 19:28:02 UTC) #2
Ilya Sherman
http://codereview.chromium.org/7903001/diff/1/chrome/browser/resources/options/autofill_options_list.js File chrome/browser/resources/options/autofill_options_list.js (right): http://codereview.chromium.org/7903001/diff/1/chrome/browser/resources/options/autofill_options_list.js#newcode325 chrome/browser/resources/options/autofill_options_list.js:325: if (selectedItem) On 2011/09/15 19:28:02, James Hawkins wrote: > ...
9 years, 3 months ago (2011-09-15 20:39:01 UTC) #3
Ilya Sherman
Ping.
9 years, 3 months ago (2011-09-19 21:24:21 UTC) #4
James Hawkins
LGTM http://codereview.chromium.org/7903001/diff/5001/chrome/browser/resources/options/inline_editable_list.js File chrome/browser/resources/options/inline_editable_list.js (left): http://codereview.chromium.org/7903001/diff/5001/chrome/browser/resources/options/inline_editable_list.js#oldcode145 chrome/browser/resources/options/inline_editable_list.js:145: if (self.editing && self.focusPlaceholder) { You're right. I ...
9 years, 3 months ago (2011-09-19 23:00:06 UTC) #5
Ilya Sherman
arv, would you like me to wait for your review? (Will commit tomorrow if I ...
9 years, 3 months ago (2011-09-19 23:57:43 UTC) #6
commit-bot: I haz the power
9 years, 3 months ago (2011-09-20 23:49:25 UTC) #7
Change committed as 102055

Powered by Google App Engine
This is Rietveld 408576698