Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: chrome/browser/resources/options/inline_editable_list.js

Issue 7903001: Improve Tab-key navigation for editing Autofill addresses and credit cards. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: De-nitting Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/inline_editable_list.js
diff --git a/chrome/browser/resources/options/inline_editable_list.js b/chrome/browser/resources/options/inline_editable_list.js
index 6cd088667f92dfe1c623efc5e869003d7b01e92e..8aed93beedf423fe5d24ca8c6f317fa50979672e 100644
--- a/chrome/browser/resources/options/inline_editable_list.js
+++ b/chrome/browser/resources/options/inline_editable_list.js
@@ -83,18 +83,6 @@ cr.define('options', function() {
},
/**
- * Called when the input element receives focus. Selects this item in the
- * list selection model.
- * @private
- */
- handleFocus_: function() {
- var list = this.parentNode;
- var index = list.getIndexOfListItem(this);
- list.selectionModel.selectedIndex = index;
- list.selectionModel.anchorIndex = index;
- },
-
- /**
* Called when this element gains or loses 'lead' status. Updates editing
* mode accordingly.
* @private
@@ -142,7 +130,7 @@ cr.define('options', function() {
if (focusElement) {
window.setTimeout(function() {
// Make sure we are still in edit mode by the time we execute.
- if (self.editing && self.focusPlaceholder) {
James Hawkins 2011/09/19 23:00:07 You're right. I checked it out, and this check is
+ if (self.editing) {
focusElement.focus();
focusElement.select();
}
« no previous file with comments | « chrome/browser/resources/options/deletable_item_list.js ('k') | chrome/browser/resources/shared/js/cr/ui/list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698