Adds Find method to the ListValue class.

Adds Find method to the ListValue class.

This method makes working with lists easierand will be needed from the
refactored signed settings code.

BUG=chromium-os:14054
TEST=base_unittest --gtest_filter=ValuesTest.List


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101741

[pastarmovj, 2011-09-15 11:55:36]

A small useful addition to the ListValue type which will replace some calls to
IsEmailInUserlist and similar in the refactored SignedSettings.

[pastarmovj, 2011-09-15 11:56:11]

On 2011/09/15 11:55:36, pastarmovj wrote:
> A small useful addition to the ListValue type which will replace some calls to
> IsEmailInUserlist and similar in the refactored SignedSettings.

btw I ran trybots already and they are all green I just started them before the
upload.

[Mattias Nissler (ping if slow), 2011-09-15 12:01:10]

Seems like std::find() should do the trick?

[pastarmovj, 2011-09-15 13:31:59]

Tuned it up as we discussed offline. I decided against exposing completely the
Compare functor to the outside world but at least now other functions can use it
as well so that for example Dictionary find can be implemented or some
RemoveIfEquals can be done etc.

[Mattias Nissler (ping if slow), 2011-09-15 13:40:39]

please also run this by a base/ OWNER.

http://codereview.chromium.org/7892052/diff/3002/base/values.cc
File base/values.cc (right):

http://codereview.chromium.org/7892052/diff/3002/base/values.cc#newcode62
base/values.cc:62: class CompareValues {
Maybe ValueEquals? It isn't really useful as a comparator.

http://codereview.chromium.org/7892052/diff/3002/base/values.cc#newcode71
base/values.cc:71: const Value& first_;
In chromium, we'd usually use a pointer for this. Also, you should put a comment
on the constructor saying that the passed-in value must stay valid for the
lifetime of this.

http://codereview.chromium.org/7892052/diff/3002/base/values.h
File base/values.h (right):

http://codereview.chromium.org/7892052/diff/3002/base/values.h#newcode421
base/values.h:421: // Searches for the first instance of |value| in the list.
Maybe mention that this compares using Equals()?

[pastarmovj, 2011-09-16 08:03:49]

Adding Darin for owner approval.

http://codereview.chromium.org/7892052/diff/3002/base/values.cc
File base/values.cc (right):

http://codereview.chromium.org/7892052/diff/3002/base/values.cc#newcode62
base/values.cc:62: class CompareValues {
On 2011/09/15 13:40:39, Mattias Nissler wrote:
> Maybe ValueEquals? It isn't really useful as a comparator.

Done. Actually picked something even more specific.

http://codereview.chromium.org/7892052/diff/3002/base/values.cc#newcode71
base/values.cc:71: const Value& first_;
On 2011/09/15 13:40:39, Mattias Nissler wrote:
> In chromium, we'd usually use a pointer for this. Also, you should put a
comment
> on the constructor saying that the passed-in value must stay valid for the
> lifetime of this.

Done.

http://codereview.chromium.org/7892052/diff/3002/base/values.h
File base/values.h (right):

http://codereview.chromium.org/7892052/diff/3002/base/values.h#newcode421
base/values.h:421: // Searches for the first instance of |value| in the list.
On 2011/09/15 13:40:39, Mattias Nissler wrote:
> Maybe mention that this compares using Equals()?

Done.

[darin (slow to review), 2011-09-17 04:59:05]

OK, LGTM

[commit-bot: I haz the power, 2011-09-19 15:23:13]

Change committed as 101741