Adds Find method to the ListValue class.

base/values.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/values.h"
 
 #include "base/float_util.h"
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
@@ skipping 40 matching lines @@
       delete copy;
       return NULL;
     }
 
     default:
       // For everything else, just make a copy.
       return node->DeepCopy();
   }
 }
 
+// A small functor for comparing Values for std::find_if and similar.
+class CompareValues {

[Mattias Nissler (ping if slow), 2011/09/15 13:40:39]

Maybe ValueEquals? It isn't really useful as a comparator.

[pastarmovj, 2011/09/16 08:03:49]

Done. Actually picked something even more specific.

+ public:
+  CompareValues(const Value& first) : first_(first) { }
+
+  bool operator ()(const Value* second) const {
+    return first_.Equals(second);
+  }
+
+ private:
+  const Value& first_;

[Mattias Nissler (ping if slow), 2011/09/15 13:40:39]

In chromium, we'd usually use a pointer for this. Also, you should put a comment
on the constructor saying that the passed-in value must stay valid for the
lifetime of this.

[pastarmovj, 2011/09/16 08:03:49]

Done.

+};
+
 }  // namespace
 
 namespace base {
 
 ///////////////////// Value ////////////////////
 
 Value::~Value() {
 }
 
 // static
@@ skipping 787 matching lines @@
 
 bool ListValue::Insert(size_t index, Value* in_value) {
   DCHECK(in_value);
   if (index > list_.size())
     return false;
 
   list_.insert(list_.begin() + index, in_value);
   return true;
 }
 
+ListValue::const_iterator ListValue::Find(const Value& value) const {
+  CompareValues compare(value);
+  return std::find_if(list_.begin(), list_.end(), compare);
+}
+
 bool ListValue::GetAsList(ListValue** out_value) {
   if (out_value)
     *out_value = this;
   return true;
 }
 
 bool ListValue::GetAsList(const ListValue** out_value) const {
   if (out_value)
     *out_value = this;
   return true;
@@ skipping 24 matching lines @@
   if (lhs_it != end() || rhs_it != other_list->end())
     return false;
 
   return true;
 }
 
 ValueSerializer::~ValueSerializer() {
 }
 
 }  // namespace base