Autofill: Remove fax number completely.

chrome/browser/autofill/phone_field.h

Index: chrome/browser/autofill/phone_field.h
diff --git a/chrome/browser/autofill/phone_field.h b/chrome/browser/autofill/phone_field.h
index c4f9122e0130a1d1820987e407d90ee3445b668f..22d476017755ea780e129fb21eb0b1dff83f6943 100644
--- a/chrome/browser/autofill/phone_field.h
+++ b/chrome/browser/autofill/phone_field.h
@@ -37,23 +37,11 @@ class PhoneField : public FormField {
   FRIEND_TEST_ALL_PREFIXES(PhoneFieldTest, ThreePartPhoneNumber);
   FRIEND_TEST_ALL_PREFIXES(PhoneFieldTest, ThreePartPhoneNumberPrefixSuffix);
   FRIEND_TEST_ALL_PREFIXES(PhoneFieldTest, ThreePartPhoneNumberPrefixSuffix2);
-  FRIEND_TEST_ALL_PREFIXES(PhoneFieldTest, ParseOneLineFax);
-  FRIEND_TEST_ALL_PREFIXES(PhoneFieldTest, ParseTwoLineFax);
-  FRIEND_TEST_ALL_PREFIXES(PhoneFieldTest, ThreePartFaxNumberPrefixSuffix);
   FRIEND_TEST_ALL_PREFIXES(PhoneFieldTest, CountryAndCityAndPhoneNumber);
 
   PhoneField();
 
-  enum PhoneType {
-    PHONE_TYPE_FIRST = 0,
-    HOME_PHONE = PHONE_TYPE_FIRST,
-    FAX_PHONE,
-
-    // Must be last.
-    PHONE_TYPE_MAX,
-  };
-
-  // Some field names are different for phone and fax.
+  // Some field names are different for phone.

[Ilya Sherman, 2011/09/15 03:47:08]

nit: This comment no longer makes sense.  I think all of these methods can be
inlined into GetRegExp().

[James Hawkins, 2011/09/16 03:23:28]

Done.

   string16 GetCountryRegex() const;
   // This string includes all area code separators, including NoText.
   string16 GetAreaRegex() const;
@@ -91,19 +79,11 @@ class PhoneField : public FormField {
   // |iter| - in/out. Form field iterator, points to the first field that is
   //   attempted to be parsed. If parsing successful, points to the first field
   //   after parsed fields.
-  // |regular_phone| - true if the parsed phone is a HOME phone, false
-  //   otherwise.
-  static bool ParseInternal(PhoneField* field,
-                            AutofillScanner* scanner,
-                            bool regular_phone);
+  // TODO(isherman): This method doc is out of date.
+  static bool ParseInternal(PhoneField* field, AutofillScanner* scanner);
 
-  void SetPhoneType(PhoneType phone_type);
-
-  // Field types are different as well, so we create a temporary phone number,
-  // to get relevant field types.
+  // TODO(jhawkins): This is probably not necessary anymore.

[Ilya Sherman, 2011/09/15 03:47:08]

Indeed, I think you can nix it.

[James Hawkins, 2011/09/16 03:23:28]

Done.

   scoped_ptr<PhoneNumber> number_;
-  PhoneType phone_type_;
-
 
   // Parsed fields.
   enum PhonePart {