Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: sql/connection.cc

Issue 7891025: [SQLite] Hack to touch page cache to debug slow connection close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Windows compile. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/sqlite/amalgamation/sqlite3.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sql/connection.cc
diff --git a/sql/connection.cc b/sql/connection.cc
index 0f2df97f79b08bb9cf7bda12e803f6a73712e5e8..bda1d26ccd7bb1761a55a919fb9fd49c7d903812 100644
--- a/sql/connection.cc
+++ b/sql/connection.cc
@@ -111,6 +111,20 @@ void Connection::Close() {
statement_cache_.clear();
DCHECK(open_statements_.empty());
if (db_) {
+ // TODO(shess): Some additional code to debug http://crbug.com/95527 .
+ // If you are reading this due to link errors or something, it can
+ // be safely removed.
+#if defined(HAS_SQLITE3_95527)
+ unsigned int nTouched = 0;
+ sqlite3_95527(db_, &nTouched);
+
+ // If a VERY large amount of memory was touched, crash. This
+ // should never happen.
+ // TODO(shess): Pull this in. It should be page_size * page_cache
+ // or something like that, 4M or 16M. For now it's just to
+ // prevent optimization.
+ CHECK_LT(nTouched, 1000*1000*1000U);
+#endif
sqlite3_close(db_);
db_ = NULL;
}
« no previous file with comments | « no previous file | third_party/sqlite/amalgamation/sqlite3.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698