Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 7890060: This broke lots of layout tests on OSX. (Closed)

Created:
9 years, 3 months ago by levin
Modified:
9 years, 3 months ago
Reviewers:
marcvs
CC:
chromium-reviews, GeorgeY, amit, pam+watch_chromium.org, Paweł Hajdan Jr., Ilya Sherman, dhollowa
Visibility:
Public.

Description

This broke lots of layout tests on OSX. See this link for the failure list: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT - chromium.org&tests=fast/dom/HTMLTextAreaElement/reset-textarea.html,fast/dom/isindex-001.html,fast/dom/isindex-002.html,fast/forms/blankbuttons.html,fast/forms/box-shadow-override.html,fast/forms/button-default-title.html,fast/forms/file-input-direction.html,fast/forms/hidden-input-file.html,fast/forms/input-appearance-height.html,fast/forms/input-file-re-render.html,fast/forms/input-first-letter.html,fast/forms/isindex-placeholder.html,fast/forms/text-style-color.html,fast/forms/validation-message-appearance.html,fast/html/details-no-summary1.html,fast/html/details-no-summary2.html,fast/html/details-no-summary3.html,fast/html/details-no-summary4.html,fast/html/details-remove-summary-1-and-click.html,fast/html/details-remove-summary-1.html,fast/html/details-remove-summary-4-and-click.html,fast/html/details-remove-summary-4.html,fast/html/keygen.html,tables/mozilla/bugs/bug39209.html,tables/mozilla/bugs/bug4429.html,fast/forms/005.html,fast/forms/input-file-label.html,fast/invalid/residual-style.html,fast/parser/fragment-parser.html,fast/replaced/table-percent-height-text-controls.html,html5lib/runner.html,http/tests/misc/isindex-with-no-form-base-href.html,http/tests/misc/isindex-with-no-form.html Revert 101213 - Updated *.pak file format to support both UTF8 and UTF16 Inserted a new field in the header that specifies which encoding is to be used for the text resources. I also upped file format to version 4. BUG=76281 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100973 Review URL: http://codereview.chromium.org/7744017 TBR=adriansc@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -198 lines) Patch
M chrome/browser/autofill/autofill_regexes.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/prefs/pref_service_unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/simple_resource_loader.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M tools/data_pack/data_pack.py View 3 chunks +9 lines, -17 lines 0 comments Download
M tools/data_pack/repack.py View 1 chunk +4 lines, -16 lines 0 comments Download
M tools/grit/grit/format/data_pack.py View 6 chunks +20 lines, -41 lines 0 comments Download
M tools/grit/grit/format/data_pack_unittest.py View 1 chunk +7 lines, -9 lines 0 comments Download
M tools/grit/grit/node/include.py View 3 chunks +2 lines, -3 lines 0 comments Download
M tools/grit/grit/node/message.py View 4 chunks +6 lines, -12 lines 0 comments Download
M ui/base/resource/data_pack.h View 3 chunks +2 lines, -19 lines 0 comments Download
M ui/base/resource/data_pack.cc View 6 chunks +6 lines, -33 lines 0 comments Download
M ui/base/resource/data_pack_literal.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M ui/base/resource/data_pack_unittest.cc View 4 chunks +2 lines, -16 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 2 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
levin
9 years, 3 months ago (2011-09-15 02:14:45 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698