Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: tools/data_pack/data_pack.py

Issue 7890060: This broke lots of layout tests on OSX. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/simple_resource_loader.cc ('k') | tools/data_pack/repack.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/data_pack/data_pack.py
===================================================================
--- tools/data_pack/data_pack.py (revision 101223)
+++ tools/data_pack/data_pack.py (working copy)
@@ -12,33 +12,25 @@
import struct
-FILE_FORMAT_VERSION = 4
-HEADER_LENGTH = 2 * 4 + 1 # Two uint32s. (file version, number of entries) and
- # one uint8 (encoding of text resources)
-BINARY, UTF8, UTF16 = range(3)
+FILE_FORMAT_VERSION = 3
+HEADER_LENGTH = 2 * 4 # Two uint32s. (file version and number of entries)
class WrongFileVersion(Exception):
pass
-class DataPackContents:
- def __init__(self, resources, encoding):
- self.resources = resources
- self.encoding = encoding
-
def ReadDataPack(input_file):
"""Reads a data pack file and returns a dictionary."""
data = open(input_file, "rb").read()
original_data = data
# Read the header.
- version, num_entries, encoding = struct.unpack("<IIB", data[:HEADER_LENGTH])
+ version, num_entries = struct.unpack("<II", data[:HEADER_LENGTH])
if version != FILE_FORMAT_VERSION:
- print "Wrong file version in ", input_file
raise WrongFileVersion
resources = {}
if num_entries == 0:
- return DataPackContents(resources, encoding)
+ return resources
# Read the index and data.
data = data[HEADER_LENGTH:]
@@ -49,15 +41,15 @@
next_id, next_offset = struct.unpack("<HI", data[:kIndexEntrySize])
resources[id] = original_data[offset:next_offset]
- return DataPackContents(resources, encoding)
+ return resources
-def WriteDataPack(resources, output_file, encoding):
+def WriteDataPack(resources, output_file):
"""Write a map of id=>data into output_file as a data pack."""
ids = sorted(resources.keys())
file = open(output_file, "wb")
# Write file header.
- file.write(struct.pack("<IIB", FILE_FORMAT_VERSION, len(ids), encoding))
+ file.write(struct.pack("<II", FILE_FORMAT_VERSION, len(ids)))
# Each entry is a uint16 and a uint32. We have one extra entry for the last
# item.
@@ -78,9 +70,9 @@
def main():
# Just write a simple file.
data = { 1: "", 4: "this is id 4", 6: "this is id 6", 10: "" }
- WriteDataPack(data, "datapack1.pak", UTF8)
+ WriteDataPack(data, "datapack1.pak")
data2 = { 1000: "test", 5: "five" }
- WriteDataPack(data2, "datapack2.pak", UTF8)
+ WriteDataPack(data2, "datapack2.pak")
print "wrote datapack1 and datapack2 to current directory."
if __name__ == '__main__':
« no previous file with comments | « chrome_frame/simple_resource_loader.cc ('k') | tools/data_pack/repack.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698