Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: src/runtime.cc

Issue 7889039: Fixing issue 1639, debugger stops stepping outside evaluate. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Adding test case. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-1639-2.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 11950 matching lines...) Expand 10 before | Expand all | Expand 10 after
11961 Handle<JSFunction>( 11961 Handle<JSFunction>(
11962 isolate->factory()->NewFunctionFromSharedFunctionInfo(shared, 11962 isolate->factory()->NewFunctionFromSharedFunctionInfo(shared,
11963 context)); 11963 context));
11964 11964
11965 // Invoke the result of the compilation to get the evaluation function. 11965 // Invoke the result of the compilation to get the evaluation function.
11966 bool has_pending_exception; 11966 bool has_pending_exception;
11967 Handle<Object> receiver = isolate->global(); 11967 Handle<Object> receiver = isolate->global();
11968 Handle<Object> result = 11968 Handle<Object> result =
11969 Execution::Call(compiled_function, receiver, 0, NULL, 11969 Execution::Call(compiled_function, receiver, 0, NULL,
11970 &has_pending_exception); 11970 &has_pending_exception);
11971 // Clear the oneshot breakpoints so that the debugger does not step further.
11972 isolate->debug()->ClearStepping();
11971 if (has_pending_exception) return Failure::Exception(); 11973 if (has_pending_exception) return Failure::Exception();
11972 return *result; 11974 return *result;
11973 } 11975 }
11974 11976
11975 11977
11976 RUNTIME_FUNCTION(MaybeObject*, Runtime_DebugGetLoadedScripts) { 11978 RUNTIME_FUNCTION(MaybeObject*, Runtime_DebugGetLoadedScripts) {
11977 HandleScope scope(isolate); 11979 HandleScope scope(isolate);
11978 ASSERT(args.length() == 0); 11980 ASSERT(args.length() == 0);
11979 11981
11980 // Fill the script objects. 11982 // Fill the script objects.
(...skipping 1249 matching lines...) Expand 10 before | Expand all | Expand 10 after
13230 } else { 13232 } else {
13231 // Handle last resort GC and make sure to allow future allocations 13233 // Handle last resort GC and make sure to allow future allocations
13232 // to grow the heap without causing GCs (if possible). 13234 // to grow the heap without causing GCs (if possible).
13233 isolate->counters()->gc_last_resort_from_js()->Increment(); 13235 isolate->counters()->gc_last_resort_from_js()->Increment();
13234 isolate->heap()->CollectAllGarbage(false); 13236 isolate->heap()->CollectAllGarbage(false);
13235 } 13237 }
13236 } 13238 }
13237 13239
13238 13240
13239 } } // namespace v8::internal 13241 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-1639-2.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698