Issue 7888064: Only deliver extension messages to contexts that care.

Issue 7888064: Only deliver extension messages to contexts that care. (Closed)

Created:
9 years, 3 months ago by Aaron Boodman

Modified:
9 years, 3 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Erik does not do reviews, Paweł Hajdan Jr., mihaip+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Reland 101111 - Only deliver extension messages to contexts that care. BUG=96544, 76571 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101221

Patch Set 1 #

Patch Set 2 : second approach #

Patch Set 3 : Nail down a bit further. Only poke relevant RenderView in the case of chrome.tabs.connect(). #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -38 lines)			Patch
M	chrome/browser/debugger/extension_ports_remote_service.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/debugger/extension_ports_remote_service.cc	View		3 chunks	+4 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/extension_message_service.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_message_service.cc	View	1	2 chunks	+4 lines, -8 lines	0 comments	Download
M	chrome/browser/extensions/extension_messages_browsertest.cc	View	1 2	4 chunks	+3 lines, -10 lines	0 comments	Download
M	chrome/common/extensions/extension_messages.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/bindings_utils.h	View	1 2	1 chunk	+10 lines, -2 lines	0 comments	Download
M	chrome/renderer/extensions/bindings_utils.cc	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/event_bindings.cc	View	1 2	1 chunk	+1 line, -6 lines	0 comments	Download
M	chrome/renderer/extensions/extension_dispatcher.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/extensions/extension_dispatcher.cc	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/extension_helper.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/extension_helper.cc	View	1 2	3 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/renderer_extension_bindings.h	View	1 2	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/renderer_extension_bindings.cc	View	1 2	1 chunk	+38 lines, -0 lines	1 comment	Download
M	chrome/renderer/resources/renderer_extension_bindings.js	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

There was a bug in chrome.extension.connectToTab(). Please take a look at the changes to ExtensionMessageService::OpenChannelToTab().

9 years, 3 months ago (2011-09-14 23:23:33 UTC) #1

Matt Perry

9 years, 3 months ago (2011-09-15 01:42:37 UTC) #2

lgtm

http://codereview.chromium.org/7888064/diff/3002/chrome/renderer/extensions/r...
File chrome/renderer/extensions/renderer_extension_bindings.cc (right):

http://codereview.chromium.org/7888064/diff/3002/chrome/renderer/extensions/r...
chrome/renderer/extensions/renderer_extension_bindings.cc:271: if
(restrict_to_render_view != NULL &&
nit: chrome style is to use boolean-style checks for null.

Expand Messages | Collapse Messages