chrome/renderer/extensions/event_bindings.cc - Issue 7888064: Only deliver extension messages to contexts that care.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/event_bindings.cc

Issue 7888064: Only deliver extension messages to contexts that care. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Nail down a bit further. Only poke relevant RenderView in the case of chrome.tabs.connect(). Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/event_bindings.cc

diff --git a/chrome/renderer/extensions/event_bindings.cc b/chrome/renderer/extensions/event_bindings.cc

index 9be737b3b96ae40e91da41f5f43e73ca2c8b0f86..67a6c98db4e3c1d72ec1ad3656d6f18d9224a8fe 100644

--- a/chrome/renderer/extensions/event_bindings.cc

+++ b/chrome/renderer/extensions/event_bindings.cc

@@ -392,12 +392,7 @@ void EventBindings::CallFunction(const std::string& extension_id,

if (!extension_id.empty() && extension_id != (*it)->extension_id)

continue;

- WebFrame* context_frame = WebFrame::frameForContext((*it)->context);

- if (!context_frame || !context_frame->view())

- continue;

- RenderView* context_render_view =

- RenderView::FromWebView(context_frame->view());

+ RenderView* context_render_view = (*it)->GetRenderView();

if (!context_render_view)

continue;