Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1359)

Unified Diff: scripts/master/factory/chromium_commands.py

Issue 7888058: Add check_licenses step to the buildbot. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/master/factory/chromium_commands.py
===================================================================
--- scripts/master/factory/chromium_commands.py (revision 101166)
+++ scripts/master/factory/chromium_commands.py (working copy)
@@ -75,6 +75,7 @@
self._check_deps_tool = J('src', 'tools', 'checkdeps', 'checkdeps.py')
self._check_bins_tool = J('src', 'tools', 'checkbins', 'checkbins.py')
self._check_perms_tool = J('src', 'tools', 'checkperms', 'checkperms.py')
+ self._check_licenses_tool = J('src', 'tools', 'checklicenses', 'checklicenses.py')
nsylvain 2011/09/15 16:54:49 80 chars
Paweł Hajdan Jr. 2011/09/15 17:21:06 Done.
self._posix_memory_tests_runner = J('src', 'tools', 'valgrind',
'chrome_tests.sh')
self._win_memory_tests_runner = J('src', 'tools', 'valgrind',
@@ -192,6 +193,12 @@
self.AddTestStep(shell.ShellCommand, 'check_perms', cmd,
do_step_if=self.TestStepFilter)
+ def AddCheckLicensesStep(self):
+ cmd = [self._python, self._check_licenses_tool,
+ '--root', self._repository_root]
+ self.AddTestStep(shell.ShellCommand, 'check_licenses', cmd,
+ do_step_if=self.TestStepFilter)
+
def AddCheckLKGRStep(self):
"""Check LKGR; if unchanged, cancel the build.

Powered by Google App Engine
This is Rietveld 408576698