Added Instant preference syncing and tests.

chrome/browser/instant/instant_controller.cc

Index: chrome/browser/instant/instant_controller.cc
diff --git a/chrome/browser/instant/instant_controller.cc b/chrome/browser/instant/instant_controller.cc
index 832a2d7da2e8e035462892aa94dc8135bad3ad2e..695a79693f87ed8f49a3435b9f59f117a0de389f 100644
--- a/chrome/browser/instant/instant_controller.cc
+++ b/chrome/browser/instant/instant_controller.cc
@@ -83,16 +83,16 @@ InstantController::~InstantController() {
 void InstantController::RegisterUserPrefs(PrefService* prefs) {
   prefs->RegisterBooleanPref(prefs::kInstantConfirmDialogShown,
                              false,
-                             PrefService::UNSYNCABLE_PREF);
+                             PrefService::SYNCABLE_PREF);
   prefs->RegisterBooleanPref(prefs::kInstantEnabled,
                              false,
-                             PrefService::UNSYNCABLE_PREF);
+                             PrefService::SYNCABLE_PREF);
   prefs->RegisterBooleanPref(prefs::kInstantEnabledOnce,
                              false,
-                             PrefService::UNSYNCABLE_PREF);
+                             PrefService::SYNCABLE_PREF);
   prefs->RegisterInt64Pref(prefs::kInstantEnabledTime,
                            false,
-                           PrefService::UNSYNCABLE_PREF);
+                           PrefService::SYNCABLE_PREF);

[Nicolas Zea, 2011/09/14 21:32:12]

Have you verified that this value is cross-platform compatible? (all platforms
will understand it the same way?)

[csharp, 2011/09/15 13:39:12]

I have not, I had thought that it would be cross-platform compatible because
this is the same method used for other preferences (which I assumed are
cross-platform).

What should I read or do to ensure compatible?

On 2011/09/14 21:32:12, nzea wrote:

[Nicolas Zea, 2011/09/15 19:48:57]

Looking below, it's just a base::Time::Now().ToInternalValue. Just for the sake
of thoroughness, it would be good for you to get familiar with the base/time.h
format. Offhand I'm pretty sure we store everything internally using the windows
epoch, no matter the platform, so it should be fine.

   PromoCounter::RegisterUserPrefs(prefs, prefs::kInstantPromo);
 }