Added Instant preference syncing and tests.

chrome/browser/instant/instant_controller.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/instant/instant_controller.h"
 
 #include "base/command_line.h"
 #include "base/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/rand_util.h"
@@ skipping 65 matching lines @@
   }
 }
 
 InstantController::~InstantController() {
 }
 
 // static
 void InstantController::RegisterUserPrefs(PrefService* prefs) {
   prefs->RegisterBooleanPref(prefs::kInstantConfirmDialogShown,
                              false,
-                             PrefService::UNSYNCABLE_PREF);
+                             PrefService::SYNCABLE_PREF);
   prefs->RegisterBooleanPref(prefs::kInstantEnabled,
                              false,
-                             PrefService::UNSYNCABLE_PREF);
+                             PrefService::SYNCABLE_PREF);
   prefs->RegisterBooleanPref(prefs::kInstantEnabledOnce,
                              false,
-                             PrefService::UNSYNCABLE_PREF);
+                             PrefService::SYNCABLE_PREF);
   prefs->RegisterInt64Pref(prefs::kInstantEnabledTime,
                            false,
-                           PrefService::UNSYNCABLE_PREF);
+                           PrefService::SYNCABLE_PREF);

[Nicolas Zea, 2011/09/14 21:32:12]

Have you verified that this value is cross-platform compatible? (all platforms
will understand it the same way?)

[csharp, 2011/09/15 13:39:12]

I have not, I had thought that it would be cross-platform compatible because
this is the same method used for other preferences (which I assumed are
cross-platform).

What should I read or do to ensure compatible?

On 2011/09/14 21:32:12, nzea wrote:

[Nicolas Zea, 2011/09/15 19:48:57]

Looking below, it's just a base::Time::Now().ToInternalValue. Just for the sake
of thoroughness, it would be good for you to get familiar with the base/time.h
format. Offhand I'm pretty sure we store everything internally using the windows
epoch, no matter the platform, so it should be fine.

   PromoCounter::RegisterUserPrefs(prefs, prefs::kInstantPromo);
 }
 
 // static
 void InstantController::RecordMetrics(Profile* profile) {
   if (!IsEnabled(profile))
     return;
 
   PrefService* service = profile->GetPrefs();
   if (service) {
@@ skipping 666 matching lines @@
   if (destroy_factory_.empty()) {
     MessageLoop::current()->PostTask(
         FROM_HERE, destroy_factory_.NewRunnableMethod(
             &InstantController::DestroyLoaders));
   }
 }
 
 void InstantController::DestroyLoaders() {
   loaders_to_destroy_.reset();
 }