Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 7888030: Edit precompile to eliminate headers that define 'interface'. (Closed)

Created:
9 years, 3 months ago by Jói
Modified:
9 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Eliminate headers from precompile.h that define 'interface' to avoid compile failures on Windows that would not be seen on Mac or Linux. I didn't do an exact measurement but I think we lose very little in terms of build time from this; Windows.h is the big Windows-specific header and it's still precompiled. BUG=none TEST=it builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -117 lines) Patch
M build/precompile.h View 2 chunks +29 lines, -21 lines 0 comments Download
M webkit/glue/gl_bindings_skia_cmd_buffer.cc View 1 chunk +96 lines, -96 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jói
Brett, I renamed gl_interface in one file back (vs. http://crrev.com/99949) to just 'interface' as this ...
9 years, 3 months ago (2011-09-13 23:09:56 UTC) #1
brettw
9 years, 3 months ago (2011-09-13 23:37:53 UTC) #2
That's fine. LGTM, sorry this is so much work.

Powered by Google App Engine
This is Rietveld 408576698