Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: build/precompile.h

Issue 7888030: Edit precompile to eliminate headers that define 'interface'. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | webkit/glue/gl_bindings_skia_cmd_buffer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Precompiled header for Chromium project on Windows, not used by 5 // Precompiled header for Chromium project on Windows, not used by
6 // other build configurations. Using precompiled headers speeds the 6 // other build configurations. Using precompiled headers speeds the
7 // build up significantly, around 1/4th on VS 2010 on an HP Z600 with 12 7 // build up significantly, around 1/4th on VS 2010 on an HP Z600 with 12
8 // GB of memory. 8 // GB of memory.
9 // 9 //
10 // Numeric comments beside includes are the number of times they were 10 // Numeric comments beside includes are the number of times they were
11 // included under src/chrome/browser on 2011/8/20, which was used as a 11 // included under src/chrome/browser on 2011/8/20, which was used as a
12 // baseline for deciding what to include in the PCH. It may be 12 // baseline for deciding what to include in the PCH. It may be
13 // possible to tweak the speed of the build by commenting out or 13 // possible to tweak the speed of the build by commenting out or
14 // removing some of the less frequently used headers. 14 // removing some of the less frequently used headers.
15 15
16 #if defined(BUILD_PRECOMPILE_H_) 16 #if defined(BUILD_PRECOMPILE_H_)
17 #error You shouldn't include the precompiled header file more than once. 17 #error You shouldn't include the precompiled header file more than once.
18 #endif 18 #endif
19 19
20 #define BUILD_PRECOMPILE_H_ 20 #define BUILD_PRECOMPILE_H_
21 21
22 // The Windows header needs to come before almost all the other 22 // The Windows header needs to come before almost all the other
23 // Windows-specific headers. 23 // Windows-specific headers.
24 #include <Windows.h> 24 #include <Windows.h>
25 #include <dwmapi.h>
26 #include <shellapi.h>
27 #include <wincrypt.h> // 4
28 #include <wtypes.h> // 2
25 29
26 // TODO(joi): Defines in atlbase.h cause conflicts; need to figure out 30 // TODO(joi): Defines in atlbase.h cause conflicts; need to figure out
27 // if/how this family of headers can be included in the PCH; several 31 // if/how this family of headers can be included in the PCH; several
28 // of them are used quite frequently. 32 // of them are used quite frequently.
29 /* 33 /*
30 #include <atlbase.h> 34 #include <atlbase.h>
31 #include <atlapp.h> 35 #include <atlapp.h>
32 #include <atlcom.h> 36 #include <atlcom.h>
33 #include <atlcrack.h> // 2 37 #include <atlcrack.h> // 2
34 #include <atlctrls.h> // 2 38 #include <atlctrls.h> // 2
35 #include <atlmisc.h> // 2 39 #include <atlmisc.h> // 2
36 #include <atlsafe.h> // 1 40 #include <atlsafe.h> // 1
37 #include <atltheme.h> // 1 41 #include <atltheme.h> // 1
38 #include <atlwin.h> // 2 42 #include <atlwin.h> // 2
39 */ 43 */
40 44
41 #include <commctrl.h> // 2 45 // TODO(joi): Objbase.h and other files that rely on it bring in
42 #include <commdlg.h> // 3 46 // [ #define interface struct ] which can cause problems in a
43 #include <cryptuiapi.h> // 2 47 // multi-platform build like Chrome's. Tried #undef-ing it, but
44 #include <dwmapi.h> 48 // there are currently 118 targets that break if we do this, so
45 #include <Objbase.h> // 2 49 // leaving out of the precompiled header for now.
46 #include <objidl.h> // 1 50 //#include <commctrl.h> // 2
47 #include <ole2.h> // 1 51 //#include <commdlg.h> // 3
48 #include <oleacc.h> // 2 52 //#include <cryptuiapi.h> // 2
49 #include <oleauto.h> // 1 53 //#include <Objbase.h> // 2
50 #include <oleidl.h> // 1 54 //#include <objidl.h> // 1
51 #include <propkey.h> // 2 55 //#include <ole2.h> // 1
52 #include <propvarutil.h> // 2 56 //#include <oleacc.h> // 2
53 #include <pstore.h> // 2 57 //#include <oleauto.h> // 1
54 #include <shellapi.h> 58 //#include <oleidl.h> // 1
55 #include <shlguid.h> // 1 59 //#include <propkey.h> // 2
56 //#include <shlobj.h> TODO(joi): Caused conflicts, see if they can be resolved. 60 //#include <propvarutil.h> // 2
57 #include <shlwapi.h> // 1 61 //#include <pstore.h> // 2
58 #include <shobjidl.h> // 4 62 //#include <shlguid.h> // 1
59 #include <urlhist.h> // 2 63 //#include <shlwapi.h> // 1
60 #include <wincrypt.h> // 4 64 //#include <shobjidl.h> // 4
61 #include <wtypes.h> // 2 65 //#include <urlhist.h> // 2
66
67 // TODO(joi): Caused other conflicts in addition to the 'interface' issue
68 // above, see if they can be resolved.
69 //#include <shlobj.h>
62 70
63 #include <errno.h> 71 #include <errno.h>
64 #include <fcntl.h> 72 #include <fcntl.h>
65 #include <limits.h> // 4 73 #include <limits.h> // 4
66 #include <math.h> 74 #include <math.h>
67 #include <memory.h> // 1 75 #include <memory.h> // 1
68 #include <signal.h> 76 #include <signal.h>
69 #include <stdarg.h> // 1 77 #include <stdarg.h> // 1
70 #include <stddef.h> 78 #include <stddef.h>
71 #include <stdio.h> 79 #include <stdio.h>
(...skipping 19 matching lines...) Expand all
91 #include <map> 99 #include <map>
92 #include <numeric> // 2 100 #include <numeric> // 2
93 #include <ostream> 101 #include <ostream>
94 #include <queue> 102 #include <queue>
95 #include <set> 103 #include <set>
96 #include <sstream> 104 #include <sstream>
97 #include <stack> 105 #include <stack>
98 #include <string> 106 #include <string>
99 #include <utility> 107 #include <utility>
100 #include <vector> 108 #include <vector>
OLDNEW
« no previous file with comments | « no previous file | webkit/glue/gl_bindings_skia_cmd_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698