Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 7888012: Reorganize YUV scalers (Continued) (Closed)

Created:
9 years, 3 months ago by Alpha Left Google
Modified:
9 years, 3 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)
Visibility:
Public.

Description

Reorganize YUV scalers (Continued) After rewriting assembly code in YASM we can finally move all these different versions of files in the same folder, i.e. media/base/simd. After this change the main entry point will be: yuv_convert.cc and yuv_convert.h It then calls into the internal functions under media/base/simd. After this change I'll move all the color conversion files to media/csc. BUG=None TEST=Tree is gree Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101507

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -2689 lines) Patch
M media/base/simd/convert_rgb_to_yuv.h View 1 chunk +46 lines, -0 lines 0 comments Download
D media/base/simd/convert_rgb_to_yuv.cc View 1 chunk +0 lines, -101 lines 0 comments Download
A + media/base/simd/convert_rgb_to_yuv_c.cc View 2 chunks +1 line, -28 lines 0 comments Download
A + media/base/simd/convert_rgb_to_yuv_sse2.cc View 2 chunks +6 lines, -4 lines 0 comments Download
A + media/base/simd/convert_rgb_to_yuv_ssse3.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D media/base/simd/convert_rgb_to_yuv_x86.cc View 1 chunk +0 lines, -101 lines 0 comments Download
M media/base/simd/convert_yuv_to_rgb.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/simd/convert_yuv_to_rgb_c.cc View 1 chunk +1 line, -2 lines 0 comments Download
A media/base/simd/yuv_to_rgb_table.h View 1 chunk +26 lines, -0 lines 0 comments Download
A + media/base/simd/yuv_to_rgb_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/yuv_convert.cc View 2 chunks +18 lines, -3 lines 0 comments Download
D media/base/yuv_convert_c.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D media/base/yuv_convert_internal.h View 1 chunk +0 lines, -70 lines 0 comments Download
D media/base/yuv_convert_sse2.cc View 1 chunk +0 lines, -390 lines 0 comments Download
M media/base/yuv_convert_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
D media/base/yuv_row.h View 1 chunk +0 lines, -126 lines 0 comments Download
D media/base/yuv_row_posix.cc View 1 chunk +0 lines, -922 lines 0 comments Download
D media/base/yuv_row_table.cc View 1 chunk +0 lines, -233 lines 0 comments Download
D media/base/yuv_row_win.cc View 1 chunk +0 lines, -589 lines 0 comments Download
M media/media.gyp View 4 chunks +10 lines, -8 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Alpha Left Google
9 years, 3 months ago (2011-09-13 15:57:57 UTC) #1
Alpha Left Google
Ping.
9 years, 3 months ago (2011-09-15 18:50:07 UTC) #2
scherkus (not reviewing)
sorry for the delay -- LGTM w/ one question http://codereview.chromium.org/7888012/diff/1/media/media.gyp File media/media.gyp (right): http://codereview.chromium.org/7888012/diff/1/media/media.gyp#newcode385 media/media.gyp:385: ...
9 years, 3 months ago (2011-09-16 00:18:57 UTC) #3
Alpha Left Google
9 years, 3 months ago (2011-09-16 17:45:04 UTC) #4
On 2011/09/16 00:18:57, scherkus wrote:
> sorry for the delay -- LGTM w/ one question
> 
> http://codereview.chromium.org/7888012/diff/1/media/media.gyp
> File media/media.gyp (right):
> 
> http://codereview.chromium.org/7888012/diff/1/media/media.gyp#newcode385
> media/media.gyp:385: 'base/simd/yuv_to_rgb_table.cc',
> if the only two options are yuv_convert_simd_x86 or yuv_convert_simd_arm but
> these files are present in both... any reason to keep them separated instead
of
> as common code?
> 
> I don't care either way -- up to you and what you find is more convenient :)

I prefer to include them in the targets, it's harder to follow i think to
declare an extra target just for the common code.

Powered by Google App Engine
This is Rietveld 408576698