Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 7888004: MIPS: pre-crankshaft updates to macro-assembler and related files. (2/3) (Closed)

Created:
9 years, 3 months ago by Paul Lind
Modified:
9 years, 3 months ago
Reviewers:
Erik Corry, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: pre-crankshaft updates to macro-assembler and related files. (2/3) Highlights: - Better support for FP compares and branches (BranchF macro) - Add EmitFPUTruncate() macro, similar to EmitVFPTruncate on Arm. - Some improvements to long-branch mechanism for mips. - Add ClampUint8() and ClampDoubleToUint8() - Minor changes to ic-mips, full-codegen-mips mostly, for improved code-patching with BinaryOpStub. - Small changes to stack checking in full-codegen-mips and regexp-macro-assembler-mips BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9307

Patch Set 1 #

Patch Set 2 : removed code-patching, cache-flushing per review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+506 lines, -126 lines) Patch
M src/mips/full-codegen-mips.cc View 1 3 chunks +15 lines, -5 lines 0 comments Download
M src/mips/ic-mips.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.h View 1 18 chunks +137 lines, -47 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 26 chunks +346 lines, -68 lines 0 comments Download
M src/mips/regexp-macro-assembler-mips.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Paul Lind
9 years, 3 months ago (2011-09-13 07:24:57 UTC) #1
Paul Lind
Hmm, 2nd try on this one, did not get emailed or pushed to v8-dev list....
9 years, 3 months ago (2011-09-13 07:35:21 UTC) #2
danno
Adding Erik to take a look at the instruction cache flushing. If this is really ...
9 years, 3 months ago (2011-09-14 09:16:17 UTC) #3
danno
I see the difference, on ARM inlining the values as internal reference is probably slower ...
9 years, 3 months ago (2011-09-14 10:03:12 UTC) #4
danno
I see the difference, on ARM inlining the values as internal reference is probably slower ...
9 years, 3 months ago (2011-09-14 10:03:12 UTC) #5
Paul Lind
Updated per your comments, removed the code-patching & cache-flushing (and assembler.cc,h external references.) Will move ...
9 years, 3 months ago (2011-09-15 01:22:19 UTC) #6
danno
9 years, 3 months ago (2011-09-16 09:08:21 UTC) #7
LGTM. I'll land this for you.

Powered by Google App Engine
This is Rietveld 408576698