Issue 7885008: Fix the case where a dep not processed could be set as a requirement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7885008: Fix the case where a dep not processed could be set as a requirement. (Closed)

Created:
9 years, 3 months ago by M-A Ruel

Modified:
9 years, 3 months ago

Reviewers:
Dirk Pranke, commit-bot: I haz the power

CC:
chromium-reviews, Dirk Pranke, bmcquade1

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Fix the case where a dep not processed could be set as a requirement. This would result in a hang during gclient sync. Includes regression test. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101070

Patch Set 1 #

Patch Set 2 : works #

Total comments: 1

Patch Set 3 : comment #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -10 lines)			Patch
M	gclient.py	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	gclient_utils.py	View		2 chunks	+19 lines, -5 lines	0 comments	Download
M	tests/gclient_test.py	View	1 2	5 chunks	+17 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

LGTM otherwise. http://codereview.chromium.org/7885008/diff/2001/tests/gclient_test.py File tests/gclient_test.py (right): http://codereview.chromium.org/7885008/diff/2001/tests/gclient_test.py#newcode156 tests/gclient_test.py:156: # That is fucking weird. It doesn't ...

9 years, 3 months ago (2011-09-14 03:03:12 UTC) #3

M-A Ruel

On 2011/09/14 03:03:12, Dirk Pranke wrote: > It doesn't seem like we need to curse ...

9 years, 3 months ago (2011-09-14 12:46:57 UTC) #4

Change committed as 101070

Expand Messages | Collapse Messages