Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Unified Diff: gclient.py

Issue 7885008: Fix the case where a dep not processed could be set as a requirement. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: comment Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gclient_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient.py
diff --git a/gclient.py b/gclient.py
index ef77cd4b73cc13fe352bc5d7afad2da9fdb17388..f568662ba0db7c3811983bbbcef730b330ce4f76 100644
--- a/gclient.py
+++ b/gclient.py
@@ -224,13 +224,14 @@ class Dependency(GClientKeywords, gclient_utils.WorkItem):
if isinstance(self.url, self.FromImpl):
self.requirements.add(self.url.module_name)
- if self.name:
+ if self.name and self.should_process:
def yield_full_tree(root):
"""Depth-first recursion."""
yield root
for i in root.dependencies:
for j in yield_full_tree(i):
- yield j
+ if j.should_process:
+ yield j
for obj in yield_full_tree(self.root_parent()):
if obj is self or not obj.name:
« no previous file with comments | « no previous file | gclient_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698