[Sync] Fix encrypting of sync titles.

chrome/browser/sync/engine/nigori_util.cc

Index: chrome/browser/sync/engine/nigori_util.cc
diff --git a/chrome/browser/sync/engine/nigori_util.cc b/chrome/browser/sync/engine/nigori_util.cc
index e84e13d21d1904dbbda2582bf6094265e22af104..df7016d07fbc7d2a08d9cc38a6e838824dfdb80c 100644
--- a/chrome/browser/sync/engine/nigori_util.cc
+++ b/chrome/browser/sync/engine/nigori_util.cc
@@ -59,7 +59,12 @@ bool EntryNeedsEncryption(const ModelTypeSet& encrypted_types,
                           const Entry& entry) {
   if (!entry.Get(UNIQUE_SERVER_TAG).empty())
     return false;  // We don't encrypt unique server nodes.
-  return SpecificsNeedsEncryption(encrypted_types, entry.Get(SPECIFICS));
+  syncable::ModelType type = entry.GetModelType();
+  if (type == PASSWORDS || type == NIGORI)
+    return false;
+  return SpecificsNeedsEncryption(encrypted_types, entry.Get(SPECIFICS)) ||
+         (encrypted_types.count(type) > 0 &&
+          entry.Get(NON_UNIQUE_NAME) != kEncryptedString);

[tim (not reviewing), 2011/09/14 23:54:46]

A comment to the effect of "We check NON_UNIQUE_NAME to avoid leaking data
through that field; the field itself is not required for determining whether an
entry needs encryption." would be useful if we ever want to get rid of
NON_UNIQUE_NAME.

[Nicolas Zea, 2011/09/15 00:10:04]

Done.

 }
 
 bool SpecificsNeedsEncryption(const ModelTypeSet& encrypted_types,