[Sync] Fix encrypting of sync titles.

chrome/browser/sync/engine/nigori_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/engine/nigori_util.h"
 
 #include <queue>
 #include <string>
 #include <vector>
 
@@ skipping 41 matching lines @@
     if (EntryNeedsEncryption(encrypted_types, entry))
       return false;
   }
   return true;
 }
 
 bool EntryNeedsEncryption(const ModelTypeSet& encrypted_types,
                           const Entry& entry) {
   if (!entry.Get(UNIQUE_SERVER_TAG).empty())
     return false;  // We don't encrypt unique server nodes.
-  return SpecificsNeedsEncryption(encrypted_types, entry.Get(SPECIFICS));
+  syncable::ModelType type = entry.GetModelType();
+  if (type == PASSWORDS || type == NIGORI)
+    return false;
+  return SpecificsNeedsEncryption(encrypted_types, entry.Get(SPECIFICS)) ||
+         (encrypted_types.count(type) > 0 &&
+          entry.Get(NON_UNIQUE_NAME) != kEncryptedString);

[tim (not reviewing), 2011/09/14 23:54:46]

A comment to the effect of "We check NON_UNIQUE_NAME to avoid leaking data
through that field; the field itself is not required for determining whether an
entry needs encryption." would be useful if we ever want to get rid of
NON_UNIQUE_NAME.

[Nicolas Zea, 2011/09/15 00:10:04]

Done.

 }
 
 bool SpecificsNeedsEncryption(const ModelTypeSet& encrypted_types,
                               const sync_pb::EntitySpecifics& specifics) {
   ModelType type = GetModelTypeFromSpecifics(specifics);
   if (type == PASSWORDS || type == NIGORI)
     return false;  // These types have their own encryption schemes.
   if (encrypted_types.count(type) == 0)
     return false;  // This type does not require encryption
   return !specifics.has_encrypted();
@@ skipping 49 matching lines @@
           return false;
       }
     }
     // Push the successor.
     to_visit.push(child.Get(NEXT_ID));
   }
   return true;
 }
 
 }  // namespace syncable