[Sync] Fix encrypting of sync titles.

[Sync] Fix encrypting of sync titles.

We should always ensure we overwrite the NON_UNIQUE_NAME of sync entries
when encryption is turned on. It's only used for debugging (with a special
case for bookmarks), and can therefore safely be discarded. This fixes an
issue wherein we accidentally could resurrect old unencrypted non_unique_names.

BUG=96314
TEST=Add some extensions/apps/themes to an account with encrypt everything.
Restart sync. Verify all entries in about:sync's sync node browser list
as "encrypted".


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101254

[Nicolas Zea, 2011-09-12 23:30:15]

Only affects apps/extension/themes currently (and only because of some issue
where they rewrite all their data at startup), but should be fixed anyways. This
will also automatically fix any existing data with the unencrypted title (next
time ReEncryptEverything is called).

[Nicolas Zea, 2011-09-13 21:36:21]

ping!

[tim (not reviewing), 2011-09-14 23:54:46]

lgtm

http://codereview.chromium.org/7878005/diff/1/chrome/browser/sync/engine/nigo...
File chrome/browser/sync/engine/nigori_util.cc (right):

http://codereview.chromium.org/7878005/diff/1/chrome/browser/sync/engine/nigo...
chrome/browser/sync/engine/nigori_util.cc:67: entry.Get(NON_UNIQUE_NAME) !=
kEncryptedString);
A comment to the effect of "We check NON_UNIQUE_NAME to avoid leaking data
through that field; the field itself is not required for determining whether an
entry needs encryption." would be useful if we ever want to get rid of
NON_UNIQUE_NAME.

[Nicolas Zea, 2011-09-15 00:10:04]

Done, committing.

http://codereview.chromium.org/7878005/diff/1/chrome/browser/sync/engine/nigo...
File chrome/browser/sync/engine/nigori_util.cc (right):

http://codereview.chromium.org/7878005/diff/1/chrome/browser/sync/engine/nigo...
chrome/browser/sync/engine/nigori_util.cc:67: entry.Get(NON_UNIQUE_NAME) !=
kEncryptedString);
On 2011/09/14 23:54:46, timsteele wrote:
> A comment to the effect of "We check NON_UNIQUE_NAME to avoid leaking data
> through that field; the field itself is not required for determining whether
an
> entry needs encryption." would be useful if we ever want to get rid of
> NON_UNIQUE_NAME.

Done.

[commit-bot: I haz the power, 2011-09-15 05:54:15]

Change committed as 101254