[Mac] Break stale controller refs in infobar close.

[Mac] Break stale controller refs in infobar close.

Infobars can be closed due to a navigation while the user is
manipulating controls on the infobar.  This can result in Objective-C
messages to a deallocated controller.  If the controller is still
live, the action could attempt to dereference a NULL delegate.  This
attempts to knock down both cases.

BUG=94639, 92381
TEST=See bug, and monitor crash server.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100874

[Scott Hess - ex-Googler, 2011-09-12 21:43:13]

This might also fix http://crbug.com/92381 , or may be trivially adaptable to
fix that, I'll update here if it needs additional changes.  I wanted to get this
up ASAP as I'm OOT after Tuesday.

[Robert Sesek, 2011-09-12 21:52:49]

lgtm

[Scott Hess - ex-Googler, 2011-09-13 01:00:41]

On 2011/09/12 21:52:49, rsesek wrote:
> lgtm

Trivial change to handle breaking the link for the close button, too.  I kind of
can't believe that wasn't already fixed at some point, but there you go.

[commit-bot: I haz the power, 2011-09-13 06:00:50]

Change committed as 100874

[Nico, 2011-09-13 06:25:37]

http://codereview.chromium.org/7876004/diff/3001/chrome/browser/ui/cocoa/tran...
File chrome/browser/ui/cocoa/translate/before_translate_infobar_controller.mm
(right):

http://codereview.chromium.org/7876004/diff/3001/chrome/browser/ui/cocoa/tran...
chrome/browser/ui/cocoa/translate/before_translate_infobar_controller.mm:111:
[self delegate]->NeverTranslatePageLanguage();
Nit: s/[self delegate]/delegate/