[Mac] Break stale controller refs in infobar close.

chrome/browser/ui/cocoa/translate/translate_infobar_base.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 #import "chrome/browser/ui/cocoa/translate/translate_infobar_base.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/sys_string_conversions.h"
@@ skipping 90 matching lines @@
     [item setTarget:target];
     if (checked)
       [item setState:NSOnState];
     if (!enabled)
       [item setEnabled:NO];
   }
 }
 
 }  // namespace TranslateInfoBarUtilities
 
+namespace {
+
+// Helper to close and disable popup menus when the infobar closes.
+// Disabling the popup button would cause a distracting visual change.
+void DisablePopUpMenu(NSMenu *menu) {
+  // Remove the menu if visible.
+  [menu cancelTracking];
+
+  // If the menu is re-opened, prevent queries to update items.
+  [menu setDelegate:nil];
+
+  // Prevent target/action messages to the controller.
+  for (NSMenuItem* item in [menu itemArray]) {
+    [item setEnabled:NO];
+    [item setTarget:nil];
+  }
+}
+
+}  // namespace
+
 // TranslateInfoBarDelegate views specific method:
 InfoBar* TranslateInfoBarDelegate::CreateInfoBar(TabContentsWrapper* owner) {
   TranslateInfoBarControllerBase* infobar_controller = NULL;
   switch (type_) {
     case BEFORE_TRANSLATE:
       infobar_controller =
           [[BeforeTranslateInfobarController alloc] initWithDelegate:this
                                                                owner:owner];
       break;
     case AFTER_TRANSLATE:
@@ skipping 181 matching lines @@
 - (NSArray*)visibleControls {
   return [NSArray array];
 }
 
 - (void)rebuildOptionsMenu:(BOOL)hideTitle {
   if (![self shouldShowOptionsPopUp])
      return;
 
   // The options model doesn't know how to handle state transitions, so rebuild
   // it each time through here.
-  optionsMenuModel_.reset(
-              new OptionsMenuModel([self delegate]));
+  optionsMenuModel_.reset(new OptionsMenuModel([self delegate]));
 
   [optionsPopUp_ removeAllItems];
   // Set title.
   NSString* optionsLabel = hideTitle ? @"" :
       l10n_util::GetNSString(IDS_TRANSLATE_INFOBAR_OPTIONS);
   [optionsPopUp_ addItemWithTitle:optionsLabel];
 
    // Populate options menu.
   NSMenu* optionsMenu = [optionsPopUp_ menu];
   [optionsMenu setAutoenablesItems:NO];
@@ skipping 142 matching lines @@
   [[NSNotificationCenter defaultCenter]
       addObserver:self
          selector:@selector(didChangeFrame:)
              name:NSViewFrameDidChangeNotification
            object:infoBarView_];
   // Show and place GUI elements.
   [self updateState];
 }
 
 - (void)infobarWillClose {
-  [[optionsPopUp_ menu] cancelTracking];
+  DisablePopUpMenu([fromLanguagePopUp_ menu]);
+  DisablePopUpMenu([toLanguagePopUp_ menu]);
+  DisablePopUpMenu([optionsPopUp_ menu]);
   [super infobarWillClose];
 }
 
 - (void)adjustOptionsButtonSizeAndVisibilityForView:(NSView*)lastView {
   [optionsPopUp_ setHidden:NO];
   [self rebuildOptionsMenu:NO];
   [[optionsPopUp_ cell] setArrowPosition:NSPopUpArrowAtBottom];
   [optionsPopUp_ sizeToFit];
 
   MoveControl(closeButton_, optionsPopUp_, spaceBetweenControls_, false);
   if (!VerifyControlOrderAndSpacing(lastView, optionsPopUp_)) {
     [self rebuildOptionsMenu:YES];
     NSRect oldFrame = [optionsPopUp_ frame];
     oldFrame.size.width = NSHeight(oldFrame);
     [optionsPopUp_ setFrame:oldFrame];
     [[optionsPopUp_ cell] setArrowPosition:NSPopUpArrowAtCenter];
     MoveControl(closeButton_, optionsPopUp_, spaceBetweenControls_, false);
     if (!VerifyControlOrderAndSpacing(lastView, optionsPopUp_)) {
       [optionsPopUp_ setHidden:YES];
     }
   }
 }
 
 // Called when "Translate" button is clicked.
 - (IBAction)ok:(id)sender {
+  // The delegate may be NULL if the infobar was closed.
   TranslateInfoBarDelegate* delegate = [self delegate];
-  TranslateInfoBarDelegate::Type state = delegate->type();
-  DCHECK(state == TranslateInfoBarDelegate::BEFORE_TRANSLATE ||
-      state == TranslateInfoBarDelegate::TRANSLATION_ERROR);
-  delegate->Translate();
+  if (delegate) {
+    TranslateInfoBarDelegate::Type state = delegate->type();
+    DCHECK(state == TranslateInfoBarDelegate::BEFORE_TRANSLATE ||
+           state == TranslateInfoBarDelegate::TRANSLATION_ERROR);
+    delegate->Translate();
+  }
   UMA_HISTOGRAM_COUNTS("Translate.Translate", 1);
 }
 
 // Called when someone clicks on the "Nope" button.
 - (IBAction)cancel:(id)sender {
-  DCHECK(
-      [self delegate]->type() == TranslateInfoBarDelegate::BEFORE_TRANSLATE);
-  [self delegate]->TranslationDeclined();
-  UMA_HISTOGRAM_COUNTS("Translate.DeclineTranslate", 1);
+  // The delegate may be NULL if the infobar was closed.
+  TranslateInfoBarDelegate* delegate = [self delegate];
+  if (delegate) {
+    DCHECK(delegate->type() == TranslateInfoBarDelegate::BEFORE_TRANSLATE);
+    delegate->TranslationDeclined();
+    UMA_HISTOGRAM_COUNTS("Translate.DeclineTranslate", 1);
+  }
   [super dismiss:nil];
 }
 
 - (void)messageButtonPressed:(id)sender {
-  [self delegate]->MessageInfoBarButtonPressed();
+  // The delegate may be NULL if the infobar was closed.
+  TranslateInfoBarDelegate* delegate = [self delegate];
+  if (delegate)
+    delegate->MessageInfoBarButtonPressed();
 }
 
 - (IBAction)showOriginal:(id)sender {
-  [self delegate]->RevertTranslation();
+  // The delegate may be NULL if the infobar was closed.
+  TranslateInfoBarDelegate* delegate = [self delegate];
+  if (delegate)
+    delegate->RevertTranslation();
 }
 
 // Called when any of the language drop down menus are changed.
 - (void)languageMenuChanged:(id)item {
+  // The delegate may be NULL if the infobar was closed.
+  if (![self delegate])
+    return;
   if ([item respondsToSelector:@selector(tag)]) {
     int cmd = [item tag];
     if (cmd >= IDC_TRANSLATE_TARGET_LANGUAGE_BASE) {
       cmd -= IDC_TRANSLATE_TARGET_LANGUAGE_BASE;
       [self targetLanguageModified:cmd];
       return;
     } else if (cmd >= IDC_TRANSLATE_ORIGINAL_LANGUAGE_BASE) {
       cmd -= IDC_TRANSLATE_ORIGINAL_LANGUAGE_BASE;
       [self sourceLanguageModified:cmd];
       return;
@@ skipping 10 matching lines @@
     // "About Translate" can open a new tab).
     // Do not access member variables after this line!
     optionsMenuModel_->ExecuteCommand(cmd);
   } else {
     NOTREACHED();
   }
 }
 
 - (void)dealloc {
   [[NSNotificationCenter defaultCenter] removeObserver:self];
+  [showOriginalButton_ setTarget:nil];
+  [translateMessageButton_ setTarget:nil];
   [super dealloc];
 }
 
 #pragma mark NSMenuDelegate
 
 // Invoked by virtue of us being set as the delegate for the options menu.
 - (void)menuNeedsUpdate:(NSMenu *)menu {
   [self adjustOptionsButtonSizeAndVisibilityForView:
       [[self visibleControls] lastObject]];
 }
@@ skipping 67 matching lines @@
       return false;
     }
     previousControl = control;
   }
 
   return true;
 }
 
 @end // TranslateInfoBarControllerBase (TestingAPI)