Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/plugin/plugin_channel.h

Issue 7870008: Wait properly for renderer crashes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix win? Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/automation/automation_proxy.h ('K') | « content/common/gpu/gpu_channel_manager.cc ('k') | content/plugin/plugin_thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/plugin/plugin_channel.h
diff --git a/content/plugin/plugin_channel.h b/content/plugin/plugin_channel.h
index 4439920785252b8bfa4ccd48b6b17ee6e1807ccc..c59ca9b5fd027b49d0d321946f1b0a9d9458f107 100644
--- a/content/plugin/plugin_channel.h
+++ b/content/plugin/plugin_channel.h
@@ -51,7 +51,9 @@ class PluginChannel : public PluginChannelBase {
void set_incognito(bool value) { incognito_ = value; }
#if defined(OS_POSIX)
- int renderer_fd() const { return channel_->GetClientFileDescriptor(); }
+ int TakeClientFileDescriptor() {
darin (slow to review) 2011/09/15 05:43:37 would it help to name this TakeRendererFileDescrip
Paweł Hajdan Jr. 2011/09/15 18:36:44 Done.
+ return channel_->TakeClientFileDescriptor();
+ }
#endif
protected:
« chrome/test/automation/automation_proxy.h ('K') | « content/common/gpu/gpu_channel_manager.cc ('k') | content/plugin/plugin_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698