Wait properly for renderer crashes

content/plugin/plugin_channel.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PLUGIN_PLUGIN_CHANNEL_H_
 #define CONTENT_PLUGIN_PLUGIN_CHANNEL_H_
 #pragma once
 
 #include <vector>
 #include "base/memory/ref_counted.h"
@@ skipping 33 matching lines @@
   // Returns the event that's set when a call to the renderer causes a modal
   // dialog to come up.
   base::WaitableEvent* GetModalDialogEvent(gfx::NativeViewId containing_window);
 
   bool in_send() { return in_send_ != 0; }
 
   bool incognito() { return incognito_; }
   void set_incognito(bool value) { incognito_ = value; }
 
 #if defined(OS_POSIX)
-  int renderer_fd() const { return channel_->GetClientFileDescriptor(); }
+  int TakeClientFileDescriptor() {

[darin (slow to review), 2011/09/15 05:43:37]

would it help to name this TakeRendererFileDescriptor just as we do for
GpuChannel?

[Paweł Hajdan Jr., 2011/09/15 18:36:44]

Done.

+    return channel_->TakeClientFileDescriptor();
+  }
 #endif
 
  protected:
   // IPC::Channel::Listener implementation:
   virtual void OnChannelConnected(int32 peer_pid) OVERRIDE;
   virtual void OnChannelError() OVERRIDE;
 
   virtual void CleanUp();
 
   // Overrides PluginChannelBase::Init.
@@ skipping 27 matching lines @@
 
   int in_send_;  // Tracks if we're in a Send call.
   bool log_messages_;  // True if we should log sent and received messages.
   bool incognito_; // True if the renderer is in incognito mode.
   scoped_refptr<MessageFilter> filter_;  // Handles the modal dialog events.
 
   DISALLOW_COPY_AND_ASSIGN(PluginChannel);
 };
 
 #endif  // CONTENT_PLUGIN_PLUGIN_CHANNEL_H_