Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2448)

Unified Diff: chrome/browser/ui/webui/crashes_ui.cc

Issue 7867044: PART1: Initiated the SignedSettings refactoring. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed the comments from Denis. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/crashes_ui.cc
diff --git a/chrome/browser/ui/webui/crashes_ui.cc b/chrome/browser/ui/webui/crashes_ui.cc
index ef5c041e3fd146bc5057ce8f1258fed59070cc15..65db25be50c19e9949639315aba502e2f06389b9 100644
--- a/chrome/browser/ui/webui/crashes_ui.cc
+++ b/chrome/browser/ui/webui/crashes_ui.cc
@@ -28,7 +28,7 @@
#include "ui/base/resource/resource_bundle.h"
#if defined(OS_CHROMEOS)
-#include "chrome/browser/chromeos/user_cros_settings_provider.h"
+#include "chrome/browser/chromeos/cros_settings.h"
#endif
namespace {
@@ -176,7 +176,13 @@ bool CrashesUI::CrashReportingEnabled() {
PrefService* prefs = g_browser_process->local_state();
return prefs->GetBoolean(prefs::kMetricsReportingEnabled);
#elif defined(GOOGLE_CHROME_BUILD) && defined(OS_CHROMEOS)
- return chromeos::UserCrosSettingsProvider::cached_reporting_enabled();
+ bool reporting_enabled;
+ if (chromeos::CrosSettings::Get()->GetBoolean(chromeos::kStatsReportingPref,
+ &reporting_enabled)) {
+ return reporting_enabled;
+ }
+ NOTREACHED() << "Error occurred while accessing the pref value!";
Mattias Nissler (ping if slow) 2011/09/21 11:12:59 This seems awkward. Is there any code actually doi
pastarmovj 2011/09/23 15:19:32 Done.
+ return false;
#else
return false;
#endif

Powered by Google App Engine
This is Rietveld 408576698