PART1: Initiated the SignedSettings refactoring.

chrome/browser/ui/webui/crashes_ui.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/crashes_ui.h"
 
 #include "base/i18n/time_formatting.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
@@ skipping 10 matching lines @@
 #include "content/browser/tab_contents/tab_contents.h"
 #include "grit/browser_resources.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "grit/theme_resources_standard.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
 #if defined(OS_CHROMEOS)
-#include "chrome/browser/chromeos/user_cros_settings_provider.h"
+#include "chrome/browser/chromeos/cros_settings.h"
 #endif
 
 namespace {
 
 ChromeWebUIDataSource* CreateCrashesUIHTMLSource() {
   ChromeWebUIDataSource* source =
       new ChromeWebUIDataSource(chrome::kChromeUICrashesHost);
 
   source->AddLocalizedString("crashesTitle", IDS_CRASHES_TITLE);
   source->AddLocalizedString("crashCountFormat",
@@ skipping 127 matching lines @@
   return ResourceBundle::GetSharedInstance().
       LoadDataResourceBytes(IDR_SAD_FAVICON);
 }
 
 // static
 bool CrashesUI::CrashReportingEnabled() {
 #if defined(GOOGLE_CHROME_BUILD) && !defined(OS_CHROMEOS)
   PrefService* prefs = g_browser_process->local_state();
   return prefs->GetBoolean(prefs::kMetricsReportingEnabled);
 #elif defined(GOOGLE_CHROME_BUILD) && defined(OS_CHROMEOS)
-  return chromeos::UserCrosSettingsProvider::cached_reporting_enabled();
+  bool reporting_enabled;
+  if (chromeos::CrosSettings::Get()->GetBoolean(chromeos::kStatsReportingPref,
+                                                &reporting_enabled)) {
+    return reporting_enabled;
+  }
+  NOTREACHED() << "Error occurred while accessing the pref value!";

[Mattias Nissler (ping if slow), 2011/09/21 11:12:59]

This seems awkward. Is there any code actually doing useful when the return
value is false? If not, can we just move the DCHECK() into
CrosSettings::GetPref()? This would also more closely resemble PrefService,
which DCHECKs if you ask for the value of a pref that hasn't been registered.

[pastarmovj, 2011/09/23 15:19:32]

Done.

+  return false;
 #else
   return false;
 #endif
 }